Re: [Xen-devel] [PATCH] x86/altp2m: Fix style errors introduced with c/s 9abcac7ff

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.05.19 at 06:43, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 29/05/2019 05:23, Andrew Cooper wrote:
>> Drop introduced trailing whitespace, excessively long lines, mal-indention,
>> superfluous use of PRI macros for int-or-smaller types, and incorrect PRI
>> macros for gfns and mfns.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>> CC: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> And can I take this opportunity to remind all committers that `git diff
> --check` exists and to please make sure it is used as part of pre-push
> checks.

I don't think committers should do any checking. This should be part
of the review process (and even better be part of the submitter's
actions before sending out a patch). Committing should be a
mechanical act. Many of us doing build checks already goes beyond
what should really be required.

That said I've nevertheless added it to my script, but I'll drop it again
if the necessary cleaning up turns out to be too time consuming.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel