Re: [Xen-devel] [PATCH] xen: 'keyhandler' is not used in null scheduler

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On May 30, 2019, at 6:47 AM, Baodong Chen <chenbaodong@xxxxxxxxxx> wrote:
> 
> So remove 'keyhandler.h' include.
> Also add 'static' prefix for 'schud_bull_def'
> 
> Signed-off-by: Baodong Chen <chenbaodong@xxxxxxxxxx>

Thanks for the patch — these changes look good.  I think the title would be 
better something like:

xen/sched_null: Superficial clean-ups

Then just list both in bullet points; something like:

* Remove unused dependency ‘keyhandler.’h
* Make sched_null_def static

Would you mind re-sending the patch?  You can add:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Thanks,
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel