[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 06/19] xen/arm: Rework secondary_start prototype





On 29.05.19 20:06, Julien Grall wrote:
Hi,

On 20/05/2019 23:56, Stefano Stabellini wrote:
On Tue, 14 May 2019, Julien Grall wrote:
None of the parameters of secondary_start are actually used. So turn
secondary_start to a function with no parameters.

Also modify the assembly code to avoid setting-up the registers before
calling secondary_start.

It is called "start_secondary" rather than "secondary_start". Please fix
the commit message. Then you can add

Whoops, I will update it.


Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

FWIW, with the name fixed

Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>


--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.