[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3] schedule: move last_run_time to the credit scheduler privates
- To: Andrii Anisov <andrii.anisov@xxxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 31 May 2019 10:26:10 +0000
- Accept-language: en-GB, en-US
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=George.Dunlap@xxxxxxxxxx; spf=Pass smtp.mailfrom=George.Dunlap@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxxxxxxxxxxxxx
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrii Anisov <andrii_anisov@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 31 May 2019 10:26:20 +0000
- Ironport-sdr: iW+8ZKheQ0MoFDtaGkJ7fSQdFeGazh47sRsTn9vTzHEX8RyJu/IstAQHvwkKJejcCtQPBYNJRP ggjEOQ7uxRCei9sCLhHbbhDztG4yBNTsTzcubJdJA3wV4a4+qiwVeI8icg3yprhA4MzXwvUOSo h41DsBAgJigmdBQohHKTNGkRVJnevCUoV+UVoLSds/FJXVU9UbGFG98FPqiOMSavIx5PHm/rWU tJZMHYIW349zq7dWwOk4A5qRKVRox+R76a8/m03OTmnjGUws0Iok5D9kZnhlMBXJWLwL3P1WvD Vks=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVFvI6NjnplyMf+0eD/wwDS78Dc6aE5xsA
- Thread-topic: [PATCH v3] schedule: move last_run_time to the credit scheduler privates
> On May 30, 2019, at 3:15 PM, Andrii Anisov <andrii.anisov@xxxxxxxxx> wrote:
>
> From: Andrii Anisov <andrii_anisov@xxxxxxxx>
>
> The structure member last_run_time is used by credit scheduler only.
> So move it from a generic vcpu structure to the credit scheduler private
> vcpu definition.
This seems like a useful change, and the commit message has a lot of good
detail, thanks. But I’m left wondering: Is the main idea here just to
generally reduce code and data usage when not running the credit scheduler, or
is there another reason?
If it’s the first, a quick note to that effect will help put archaeologist’s
minds at ease. :-) This could probably be added on commit. (I’ll do a full
review it in a day or two if Dario doesn’t beat me to it.)
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
