Re: [Xen-devel] [PATCH v3] xen: make tracebuffer configurable

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Jun 5, 2019, at 2:27 AM, Baodong Chen <chenbaodong@xxxxxxxxxx> wrote:
> 
> Xen internal running status(trace event) will be saved to
> trace memory when enabled. trace event data and config params can be
> read/changed by system control hypercall at run time.
> 
> Can be disabled for smaller code footprint.
> 
> Signed-off-by: Baodong Chen <chenbaodong@xxxxxxxxxx>
> ---
> xen/common/Kconfig      |  9 +++++++++
> xen/common/Makefile     |  2 +-
> xen/include/xen/trace.h | 26 ++++++++++++++++++++++++++
> 3 files changed, 36 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index c838506..d908fe1 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -368,4 +368,13 @@ config DOM0_MEM
> 
>         Leave empty if you are not sure what to specify.
> 
> +config TRACEBUFFER
> +     bool "Enable tracing infrastructure"  if EXPERT = "y"
> +     default y
> +     ---help---
> +       Enable in tracing infrastructure and pre-defined tracepoints within 
> Xen.

Sorry, an editing mistake caused me to include a stray ‘in’ in this sentence 
when I suggested this text. :-)

This could be removed on check-in.  With that fixed, the commit message looks 
OK to me.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel