Re: [Xen-devel] [PATCH v7 10/10] x86/microcode: always collect_cpu_info() during boot

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, May 27, 2019 at 04:31:31PM +0800, Chao Gao wrote:
> From: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> 
> Currently cpu_sig struct is not updated during boot when either:
> 
>     1. ucode_scan is set to false (e.g. no "ucode=scan" in cmdline)
>     2. initrd does not contain a microcode blob
> 
> These will result in cpu_sig.rev being 0 which affects APIC's
> check_deadline_errata() and retpoline_safe() functions.
> 
> Fix this by getting ucode revision early during boot and SMP bring up.
> While at it.

I don't understand the last "While at it" sentence. Can it be
removed?

Is this an issue with current code? If so this could be merged ahead of
the rest of the series, and should likely be patch 1.

OTOH if the issue this patch is fixing is introduced by this series
please merge the fix with the respective patch that introduced the
bug.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel