|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [xen-4.12-testing test] 137475: regressions - FAIL
flight 137475 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/137475/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 16 guest-saverestore.2 fail REGR. vs. 136728 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 7 xen-boot fail in 137384 pass in 137475 test-amd64-i386-xl-qemut-ws16-amd64 13 guest-saverestore fail in 137384 pass in 137475 test-amd64-i386-xl-pvshim 7 xen-boot fail pass in 137384 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore.2 fail pass in 137384 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 12 guest-start fail in 137384 never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-install fail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass test-amd64-amd64-xl-qemut-win10-i386 10 windows-install fail never pass test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass version targeted for testing: xen 967627141b331657fff141e8e2952674753d0682 baseline version: xen b4f291b0ca914454cbac9fa5580bb35f8ab04eee Last test of basis 136728 2019-05-22 00:27:39 Z 19 days Testing same since 137278 2019-06-04 14:05:59 Z 5 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx> Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Brian Woods <brian.woods@xxxxxxx> George Dunlap <george.dunlap@xxxxxxxxxx> Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> Jan Beulich <jbeulich@xxxxxxxx> Juergen Gross <jgross@xxxxxxxx> Kevin Tian <kevin.tian@xxxxxxxxx> Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> Tamas K Lengyel <tamas@xxxxxxxxxxxxx> jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-xl-qemut-win10-i386 fail test-amd64-i386-xl-qemut-win10-i386 fail test-amd64-amd64-xl-qemuu-win10-i386 fail test-amd64-i386-xl-qemuu-win10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 967627141b331657fff141e8e2952674753d0682 Author: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> Date: Tue Jun 4 15:40:37 2019 +0200 libacpi: report PCI slots as enabled only for hotpluggable devices DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method doesn't exist then the slot is assumed to be always present and active which in conjunction with _EJ0 method makes every device ejectable for an OS even if it's not the case. qemu-kvm is able to dynamically add _EJ0 method only to those slots that either have hotpluggable devices or free for PCI passthrough. As Xen lacks this capability we cannot use their way. qemu-xen-traditional DSDT has _STA method which only reports that the slot is present if there is a PCI devices hotplugged there. This is done through querying of its PCI hotplug controller. qemu-xen has similar capability that reports if device is "hotpluggable or absent" which we can use to achieve the same result. Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> master commit: 6761965243b113230bed900d6105be05b28f5cea master date: 2019-05-24 10:30:21 +0200 commit c6ac10c8c4989e1ad6c5a90fb367c45edcb5883c Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Jun 4 15:40:07 2019 +0200 x86/IO-APIC: fix build with gcc9 There are a number of pointless __packed attributes which cause gcc 9 to legitimately warn: utils.c: In function 'vtd_dump_iommu_info': utils.c:287:33: error: converting a packed 'struct IO_APIC_route_entry' pointer (alignment 1) to a 'struct IO_APIC_route_remap_entry' pointer (alignment 8) may result in an unaligned pointer value [-Werror=address-of-packed-member] 287 | remap = (struct IO_APIC_route_remap_entry *) &rte; | ^~~~~~~~~~~~~~~~~~~~~~~~~ intremap.c: In function 'ioapic_rte_to_remap_entry': intremap.c:343:25: error: converting a packed 'struct IO_APIC_route_entry' pointer (alignment 1) to a 'struct IO_APIC_route_remap_entry' pointer (alignment 8) may result in an unaligned pointer value [-Werror=address-of-packed-member] 343 | remap_rte = (struct IO_APIC_route_remap_entry *) old_rte; | ^~~~~~~~~~~~~~~~~~~~~~~~~ Simply drop these attributes. Take the liberty and also re-format the structure definitions at the same time. Reported-by: Charles Arnold <carnold@xxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: ca9310b24e6205de5387e5982ccd42c35caf89d4 master date: 2019-05-24 10:19:59 +0200 commit a324e9c460227229a1bd4c2e896a0f31e5843dc5 Author: Juergen Gross <jgross@xxxxxxxx> Date: Tue Jun 4 15:39:37 2019 +0200 xen/sched: fix csched2_deinit_pdata() Commit 753ba43d6d16e688 ("xen/sched: fix credit2 smt idle handling") introduced a regression when switching cpus between cpupools. When assigning a cpu to a cpupool with credit2 being the default scheduler csched2_deinit_pdata() is called for the credit2 private data after the new scheduler's private data has been hooked to the per-cpu scheduler data. Unfortunately csched2_deinit_pdata() will cycle through all per-cpu scheduler areas it knows of for removing the cpu from the respective sibling masks including the area of the just moved cpu. This will (depending on the new scheduler) either clobber the data of the new scheduler or in case of sched_rt lead to a crash. Avoid that by removing the cpu from the list of active cpus in credit2 data first. The opposite problem is occurring when removing a cpu from a cpupool: init_pdata() of credit2 will access the per-cpu data of the old scheduler. Signed-off-by: Juergen Gross <jgross@xxxxxxxx> Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx> master commit: ffd3367ed682b6ac6f57fcb151921054dd4cce7e master date: 2019-05-17 15:41:17 +0200 commit b89fe9fdbcb98a321a27a9927e9a06aad6dc4f2b Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Jun 4 15:39:04 2019 +0200 x86emul: add support for missing {,V}PMADDWD insns Their pre-AVX512 incarnations have clearly been overlooked during much earlier work. Their memory access pattern is entirely standard, so no specific tests get added to the harness. Reported-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Tested-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: 1a48bdd599b268a2d9b7d0c45f1fd40c4892186e master date: 2019-05-16 13:43:17 +0200 commit 1e6ab8e2d44b3723642479944a1c7ad871d19dd1 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Jun 4 15:38:17 2019 +0200 x86/IRQ: avoid UB (or worse) in trace_irq_mask() Dynamically allocated CPU mask objects may be smaller than cpumask_t, so copying has to be restricted to the actual allocation size. This is particulary important since the function doesn't bail early when tracing is not active, so even production builds would be affected by potential misbehavior here. Take the opportunity and also - use initializers instead of assignment + memset(), - constify the cpumask_t input pointer, - u32 -> uint32_t. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx> master commit: 6fafb8befa99620a2d7323b9eca5c387bad1f59f master date: 2019-05-13 16:41:03 +0200 commit 69325e736d01fde8fef63858773a9ddae1a5144c Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Tue Jun 4 15:37:47 2019 +0200 x86/boot: Fix latent memory corruption with early_boot_opts_t c/s ebb26b509f "xen/x86: make VGA support selectable" added an #ifdef CONFIG_VIDEO into the middle the backing space for early_boot_opts_t, but didn't adjust the structure definition in cmdline.c This only functions correctly because the affected fields are at the end of the structure, and cmdline.c doesn't write to them in this case. To retain the slimming effect of compiling out CONFIG_VIDEO, adjust cmdline.c with enough #ifdef-ary to make C's idea of the structure match the declaration in asm. This requires adding __maybe_unused annotations to two helper functions. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> master commit: 30596213617fcf4dd7b71d244e16c8fc0acf456b master date: 2019-05-13 10:35:38 +0100 commit 136d10fe4dbea6e7f07b62faacbdcce1baad1eb0 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Tue Jun 4 15:37:18 2019 +0200 x86/svm: Fix handling of ICEBP intercepts c/s 9338a37d "x86/svm: implement debug events" added support for introspecting ICEBP debug exceptions, but didn't account for the fact that svm_get_insn_len() (previously __get_instruction_length) can fail and may already have raised #GP with the guest. If svm_get_insn_len() fails, return back to guest context rather than continuing and mistaking a trap-style VMExit for a fault-style one. Spotted by Coverity. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> Acked-by: Brian Woods <brian.woods@xxxxxxx> master commit: 1495b4ff9b4af2b9c0f12cdb6491082cecf34f86 master date: 2019-05-13 10:35:37 +0100 commit 86a2e13cbe0840edb3400ee3e752af3dc2e856d8 Author: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Date: Tue Jun 4 15:36:17 2019 +0200 drivers/video: drop framebuffer size constraints The limit 1900x1200 do not match real world devices (1900 looks like a typo, should be 1920). But in practice the limits are arbitrary and do not serve any real purpose. As discussed in "Increase framebuffer size to todays standards" thread, drop them completely. This fixes graphic console on device with 3840x2160 native resolution. Suggested-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> drivers/video: drop unused limits MAX_BPP, MAX_FONT_W, MAX_FONT_H are not used in the code at all. Suggested-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: 19600eb75aa9b1df3e4b0a4e55a5d08b957e1fd9 master date: 2019-05-13 10:13:24 +0200 master commit: 343459e34a6d32ba44a21f8b8fe4c1f69b1714c2 master date: 2019-05-13 10:12:56 +0200 commit 33f128df08e2b5236e422c0f30ad90d8cbcaedf9 Author: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Date: Tue Jun 4 15:35:35 2019 +0200 bitmap: fix bitmap_fill with zero-sized bitmap When bitmap_fill(..., 0) is called, do not try to write anything. Before this patch, it tried to write almost LONG_MAX, surely overwriting something. Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> master commit: 93df28be2d4f620caf18109222d046355ac56327 master date: 2019-05-13 10:12:00 +0200 commit 0f4974e5be6c6572e10f8cb1760e4a49871984a6 Author: Tamas K Lengyel <tamas@xxxxxxxxxxxxx> Date: Tue Jun 4 15:34:58 2019 +0200 x86/vmx: correctly gather gs_shadow value for current vCPU Currently the gs_shadow value is only cached when the vCPU is being scheduled out by Xen. Reporting this (usually) stale value through vm_event is incorrect, since it doesn't represent the actual state of the vCPU at the time the event was recorded. This prevents vm_event subscribers from correctly finding kernel structures in the guest when it is trapped while in ring3. Refresh shadow_gs value when the context being saved is for the current vCPU. Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx> Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx> master commit: f69fc1c2f36e8a74ba54c9c8fa5c904ea1ad319e master date: 2019-05-13 09:55:59 +0200 commit d0d1dfb4811f2f1253b936f3aa99e347292cbad3 Author: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> Date: Tue Jun 4 15:34:21 2019 +0200 x86/mtrr: recalculate P2M type for domains with iocaps This change reflects the logic in epte_get_entry_emt() and allows changes in guest MTTRs to be reflected in EPT for domains having direct access to certain hardware memory regions but without IOMMU context assigned (e.g. XenGT). Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> master commit: f3d880bf2be92534c5bacf11de2f561cbad550fb master date: 2019-05-13 09:54:45 +0200 commit b02bca1543f38cc3d2a644484b742768337ac302 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Jun 4 15:33:53 2019 +0200 AMD/IOMMU: disable previously enabled IOMMUs upon init failure If any IOMMUs were successfully initialized before encountering failure, the successfully enabled ones should be disabled again before cleaning up their resources. Move disable_iommu() next to enable_iommu() to avoid a forward declaration, and take the opportunity to remove stray blank lines ahead of both functions' final closing braces. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Brian Woods <brian.woods@xxxxxxx> master commit: 87a3347d476443c66c79953d77d6aef1d2bb3bbd master date: 2019-05-13 09:52:43 +0200 commit 0dcd945a675cd12d283121e9b7f1626104b60bcc Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Jun 4 15:32:55 2019 +0200 trace: fix build with gcc9 While I've not observed this myself, gcc 9 (imo validly) reportedly may complain trace.c: In function '__trace_hypercall': trace.c:826:19: error: taking address of packed member of 'struct <anonymous>' may result in an unaligned pointer value [-Werror=address-of-packed-member] 826 | uint32_t *a = d.args; and the fix is rather simple - remove the __packed attribute. Introduce a BUILD_BUG_ON() as replacement, for the unlikely case that Xen might get ported to an architecture where array alignment higher that that of its elements. Reported-by: Martin Liška <martin.liska@xxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx> master commit: 3fd3b266d4198c06e8e421ca515d9ba09ccd5155 master date: 2019-05-13 09:51:23 +0200 (qemu changes not included) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |