Re: [Xen-devel] [PATCH 1/2] argo: warn sendv() caller when ring is full

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Tue, Jun 11, 2019 at 12:16 PM Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 11/06/2019 19:43, Christopher Clark wrote:
> > On Tue, Jun 11, 2019 at 10:11 AM Nicholas Tsirakis
> > <niko.tsirakis@xxxxxxxxx> wrote:
> >> In its current state, if the destination ring is full, sendv()
> >> will requeue the message and return the rc of pending_requeue(),
> >> which will return 0 on success. This prevents the caller from
> >> distinguishing the difference between a successful write and a
> >> message that needs to be resent at a later time.
> >>
> >> Instead, capture the -EAGAIN value returned from ringbuf_insert()
> >> and *only* overwrite it if the rc of pending_requeue() is non-zero.
> >> This allows the caller to make intelligent decisions on -EAGAIN and
> >> still be alerted if the pending message fails to requeue.
> >>
> >> Signed-off-by: Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> > Thanks for the correct identification of the problem and the patch.
> >
> > Reviewed-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>
>
> So I was coming to commit this, but technically according to the
> maintainers file, ARGO is maintained by <christopher.w.clark@xxxxxxxxx>
>
> Looking at the ARGO series as committed, the patches where all From:
> gmail, SoB: baesystems.
>
> Which is the correct alias to use?

For this purpose:
Reviewed-by: Christopher Clark <christopher.w.clark@xxxxxxxxx>

thanks

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel