Re: [Xen-devel] [PATCH v2 03/10] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.19 at 23:28, <sstabellini@xxxxxxxxxx> wrote:
> On Thu, 2 May 2019, Jan Beulich wrote:
>> >>> On 30.04.19 at 23:02, <sstabellini@xxxxxxxxxx> wrote:
>> > --- a/xen/include/public/domctl.h
>> > +++ b/xen/include/public/domctl.h
>> > @@ -571,12 +571,24 @@ struct xen_domctl_bind_pt_irq {
>> >  */
>> >  #define DPCI_ADD_MAPPING         1
>> >  #define DPCI_REMOVE_MAPPING      0
>> > +/*
>> > + * Default memory policy. Corresponds to:
>> > + * Arm: MEMORY_POLICY_ARM_DEV_nGRE
>> > + * x86: MEMORY_POLICY_X86_UC
>> > + */
>> > +#define MEMORY_POLICY_DEFAULT    0
>> > +/* x86 only. Memory type UNCACHABLE */
>> > +#define MEMORY_POLICY_X86_UC     0
>> 
>> I'm afraid this may end up misleading, as on NPT and in
>> shadow mode we use UC- instead of UC afaics. Andrew,
>> do you have an opinion either way what exactly should
>> be stated here?
> 
> Ping?

To me? I've stated my opinion.

Jan

> I am happy to use any naming scheme you prefer, please provide input.





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel