Re: [Xen-devel] [PATCH v2 03/10] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy

[Julien Grall <julien.grall@xxxxxxx>]

On 17/06/2019 23:43, Stefano Stabellini wrote:
> On Tue, 7 May 2019, Julien Grall wrote:
> > > +#define MEMORY_POLICY_ARM_DEV_nGRE       0
> > > +/* Arm only. Outer Shareable, Outer/Inner Write-Back Cacheable memory */
> > > +#define MEMORY_POLICY_ARM_MEM_WB         1
> > I am wondering whether we should put Arm (resp. x86) defines under an ifdef
> > arm (resp. x86). Do you see any use in the common toolstack code of those
> > #ifdef?
> Yes, they are used in libxl_create.c. I would prefer to avoid
> introducing #ifdef here because it will allow us to get away with no
> #ifdef in libxl/xl.
Well, you can introduce an arch specific function that convert the memory 
policy. But I will leave this decision to the tools maintainers.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel