Re: [Xen-devel] [PATCH 1/4] xz: use initconst for hypervisor build

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Jun 19, 2019 at 05:50:52AM -0600, Jan Beulich wrote:
> >>> On 19.06.19 at 13:02, <roger.pau@xxxxxxxxxx> wrote:
> > Or else clang adds a .init.rodata.cst8 section to the resulting object
> > file, which is not handled by the Xen linker script and can end up
> > before the text section which contains the headers, thus resulting in
> > a not usable binary.
> 
> To be honest I'd prefer if we went with just the change suggested
> by Andrew, getting the linker script back in line with
> SPECIAL_DATA_SECTIONS. The static const items in the
> decompressors were left un-annotated intentionally, since the
> .rodata.* thingies want/need taking care of anyway. After all you
> won't (I hope) suggest also annotating the various string literals.

OK, I think regardless of the rest of the lld 8 series it is worth
sending the linker script change in order to prevent having this
orphaned section.

Andrew, since you where the one to propose it, could you please send a
formal patch?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel