Re: [Xen-devel] [PATCH] x86/svm: Drop svm_vm{load,save}() helpers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.06.19 at 14:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> Following on from c/s 7d161f6537 "x86/svm: Fix svm_vmcb_dump() when used in
> current context", there is now only a single user of svm_vmsave() remaining in
> the tree, with all users moved to svm_vm{load,save}_pa().
> 
> nv->nv_n1vmcx has a matching nv->nv_n1vmcx_pa which is always correct, and
> avoids a redundant __pa() translation behind the scenes.
> 
> With this gone, all VM{LOAD,SAVE} operations are using paddr_t's which is more
> efficient, so drop the svm_vm{load,save}() helpers to avoid uses of them
> reappearing in the future.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> It turns out I was mistaken about how complicated this was.

That was my hope, but it has been too long since I had last looked
at the nesting code in any level of detail.

> --- a/xen/include/asm-x86/hvm/svm/svm.h
> +++ b/xen/include/asm-x86/hvm/svm/svm.h
> @@ -22,9 +22,6 @@
>  
>  #include <xen/types.h>
>  
> -#define svm_vmload(x)     svm_vmload_pa(__pa(x))
> -#define svm_vmsave(x)     svm_vmsave_pa(__pa(x))
> -
>  static inline void svm_vmload_pa(paddr_t vmcb)

Down the road we may want to consider dropping the now
pointless _pa suffixes.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel