Re: [Xen-devel] [PATCH v2] viridian: unify time sources

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.19 at 10:23, <paul.durrant@xxxxxxxxxx> wrote:
> Currently, the time_ref_count enlightened time source maintains an offset
> such that time is frozen when the domain paused, but the reference_tsc
> enlightened time source does not. After migrate, the reference_tsc source
> may become invalidated (e.g. because of host cpu frequency mismatch) which
> will cause Windows to fall back to time_ref_count. Thus, the guest will
> observe a jump in time equivalent to the offset.
> 
> This patch unifies the two enlightened time sources such that the same
> offset applies to both of them. Also, it's not really necessary to have
> two different functions to calculating a 10MHz counter value, time_now() and
> raw_trc_val(), so this patch removes the latter implementation. The
> unification also allows removal of the reference_tsc_valid flag.
> 
> Whilst in the area, this patch also takes the opportunity to constify a few
> pointers which were missed in earlier patches.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

This looks okay to me now, but I don't feel qualified to give an R-b.
While not strictly applicable for a file maintained by you,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
will have to do here.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel