Re: [Xen-devel] [PATCH v2] viridian: unify time sources

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.06.19 at 15:58, <Paul.Durrant@xxxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
>> Sent: 21 June 2019 14:49
>> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx 
>> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Jan 
>> Beulich 
> <jbeulich@xxxxxxxx>;
>> Roger Pau Monne <roger.pau@xxxxxxxxxx>
>> Subject: Re: [Xen-devel] [PATCH v2] viridian: unify time sources
>> 
>> >   /*
>> > @@ -136,7 +100,7 @@ static int64_t time_ref_count(const struct domain *d)
>> >    * 128 bit number which is then shifted 64 times to the right to obtain
>> >    * the high 64 bits."
>> >    */
>> 
>> Is there a good reason for using signed offset here? If so then maybe
>> you should change the return type or check for bounds.
> 
> The offset is actually negative most of the time but the resulting reference 
> time should be unsigned so the return type of time_ref_count() does need 
> fixing.

Is switching it from int64_t to uint64_t all that's needed? I could
do this while committing (which I was about to).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel