[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 15/60] xen/sched: add domain pointer to struct sched_unit



>>> On 28.05.19 at 12:32, <jgross@xxxxxxxx> wrote:
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -253,7 +253,7 @@ static void sched_spin_unlock_double(spinlock_t *lock1, 
> spinlock_t *lock2,
>  static void sched_free_unit(struct sched_unit *unit)
>  {
>      struct sched_unit *prev_unit;
> -    struct domain *d = unit->vcpu->domain;
> +    struct domain *d = unit->domain;

As said in reply to patch 13, I think the domain pointer should be
introduced right in patch 4, to avoid changes like the above one,
and in particular to avoid missing changes like the one that would
be wanted also to has_soft_affinity().

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.