Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
> xl(1) opens xl.conf in XEN_CONFIG_DIR.
> Substitute this variable also in the man page.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  docs/man/xl.1.pod.in      | 2 +-
>  docs/man/xl.conf.5.pod.in | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
> index 3d64eaa5b2..fb17153635 100644
> --- a/docs/man/xl.1.pod.in
> +++ b/docs/man/xl.1.pod.in
> @@ -50,7 +50,7 @@ setup the bridge.
>  
>  If you specify the amount of memory dom0 has, passing B<dom0_mem> to
>  Xen, it is highly recommended to disable B<autoballoon>. Edit
> -B</etc/xen/xl.conf> and set it to 0.
> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
>  
>  =item run xl as B<root>
>  
> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> index 2beb2119a8..b16036aaeb 100644
> --- a/docs/man/xl.conf.5.pod.in
> +++ b/docs/man/xl.conf.5.pod.in
> @@ -1,6 +1,6 @@
>  =head1 NAME
>  
> -/etc/xen/xl.conf - XL Global/Host Configuration 
> +@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration 

There's a trailing whitespace, it would be worth removing it. git
complain about it.

The patch seems to depends on "Use XEN_SCRIPT_DIR to refer to
/etc/xen/scripts", but the email doesn't mention it. It would have been
useful to add a note bellow the '---' line or send in a series of patch.

Beside that:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel