[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V3 4/9] blk-zoned: update blkdev_reset_zones() with helper
- To: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
- From: Minwoo Im <minwoo.im.dev@xxxxxxxxx>
- Date: Wed, 3 Jul 2019 14:25:28 +0900
- Cc: Damien Le Moal <Damien.LeMoal@xxxxxxx>, "linux-btrace@xxxxxxxxxxxxxxx" <linux-btrace@xxxxxxxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "yuchao0@xxxxxxxxxx" <yuchao0@xxxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, Minwoo Im <minwoo.im.dev@xxxxxxxxx>, "jaegeuk@xxxxxxxxxx" <jaegeuk@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "kent.overstreet@xxxxxxxxx" <kent.overstreet@xxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 03 Jul 2019 05:25:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19-07-03 02:29:33, Chaitanya Kulkarni wrote:
> On 7/2/19 5:23 PM, Minwoo Im wrote:
> > On 19-07-02 10:42:30, Chaitanya Kulkarni wrote:
> >> This patch updates the blkdev_reset_zones() with newly introduced
> >> helper function to read the nr_sects from block device's hd_parts with
> >> the help of part_nr_sects_read().
> > Chaitanya,
> >
> > Are the first three patches split for a special reason? IMHO, it could
> > be squashed into a single one.
> >
> > It looks good to me, by the way.
>
> In the blk-zoned.c in this way it is easier to bisect if/when the problem
>
> comes.
Oh okay. That makes sense.
Thanks, Chaitanya.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|