Re: [Xen-devel] [PATCH v2 1/5] x86/cpuidle: switch to uniform meaning of "max_cstate="

[Jan Beulich <JBeulich@xxxxxxxx>]

On 03.07.2019 15:35, Alexandru Stefan ISAILA wrote:
> 
> 
> On 03.07.2019 16:24, Jan Beulich wrote:
>> On 03.07.2019 15:22, Alexandru Stefan ISAILA wrote:
>>>> --- a/xen/arch/x86/cpu/mwait-idle.c
>>>> +++ b/xen/arch/x86/cpu/mwait-idle.c
>>>> @@ -731,7 +731,8 @@ static void mwait_idle(void)
>>>>                    } while (cx->type > max_cstate && --next_state);
>>>>                    if (!next_state)
>>>>                            cx = NULL;
>>>> -          menu_get_trace_data(&exp, &pred);
>>>> +          else if (tb_init_done)
>>>> +                  menu_get_trace_data(&exp, &pred);
>>>
>>> Style ??
>>
>> I don't see any style violation here, comparing with neighboring
>> code. Please clarify.
>>
> 
> I saw that that file has a different spacing on if/while but I looked in
> the directory (arch/8x6/cpu) and there is a style mix like in
> vpmu.c/shanghai.c/vpmu_amd.c/vmpu_intel.c vs the rest. I was thinking
> that the new code should be with the new rules.

Such style consideration is generally to be applied per-file. There
are bad examples where styles are even mixed within a file, yes. In
the case here though the Linux style was retained to ease the porting
over of Linux side changes.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel