Re: [Xen-devel] [PATCH] include/public/io/ring.h: Remove xen_mb, xen_rmb, xen_wmb macros

[Jan Beulich <JBeulich@xxxxxxxx>]

On 04.07.2019 17:15, Anthony PERARD wrote:
> Those macros where introduced when a prefix "xen_" was added to
> mb,rmb,wmb. There are gated on __XEN_INTERFACE_VERSION__, but there
> are not part of the Xen interface. Users of ring.h needs to provide
> xen_[rw]?mb() anywai because [rw]?mb() isn't likely to exist.

It's not clear to me what you want to achieve:

> @@ -42,14 +49,6 @@
>    * and grant_table.h from the Xen public headers.
>    */
>   
> -#include "../xen-compat.h"
> -
> -#if __XEN_INTERFACE_VERSION__ < 0x00030208
> -#define xen_mb()  mb()
> -#define xen_rmb() rmb()
> -#define xen_wmb() wmb()
> -#endif

They're already not polluting the name space for any modern consumer.
And you're risking to break old verbatim users of the header. Such
compatibility stuff can, in my opinion, simply never go away.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel