Re: [Xen-devel] [PATCH v2] x86/mm: Clean IOMMU flags from p2m-pt code

[Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>]

> On 03.07.2019 14:50, Alexandru Stefan ISAILA wrote:
>> At this moment IOMMU pt sharing is disabled by commit [1].
>>
>> This patch aims to clear the IOMMU hap share support as it will not be
>> used in the future. By doing this the IOMMU bits used in pte[52:58] can
>> be used in other ways.
>>
>> [1] c2ba3db31ef2d9f1e40e7b6c16cf3be3d671d555
> 
> This all makes it sound as if this was generally the case, but it's
> so only on the AMD side. On VT-d / VT-x page table sharing continues
> to work. But it may be just me that I'd prefer this to not be implied
> from the mention of p2m-pt in the title, so I'll leave it to George
> as the maintainer to decide whether a further change to the
> description is needed.
> 
> And then I would of course have wished that a cleanup patch like this
> one dealt with both sides, i.e. removed pt sharing remains from
> xen/drivers/passthrough/amd/ at the same time (i.e. if not in one
> patch, then at least in the same series). But this may again be just
> me ...
> 

Just to clarify, are you talking about the amd_iommu_share_p2m() 
function that will not be called any more if the iommu_hap_pt_share flag 
will be deleted? If so I can add this in a 2 patch series.

Alex

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel