Re: [Xen-devel] [PATCH v3] xen/arm: domain_build: Black list devices using PPIs

[Julien Grall <julien.grall@xxxxxxx>]

Hi Amit,

On 6/23/19 1:56 PM, Amit Singh Tomar wrote:
> Currently, the vGIC is not able to cope with hardware PPIs routed to guests.
> One of the solutions to this problem is to skip any device that uses PPI
> source completely while building the domain itself.
>
> This patch goes through all the interrupt sources of a device and skip it
> if one of the interrupts sources is a PPI. It fixes XEN boot on i.MX8MQ by
> skipping the PMU node.
>
> Suggested-by:  Julien Grall <julien.grall@xxxxxxx>
> Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
With one minor change (see below):

Acked-by: Julien Grall <julien.grall@xxxxxxx>


> @@ -1400,6 +1400,24 @@ static int __init handle_node(struct domain *d, struct 
> kernel_info *kinfo,
>       }
>   
>       /*
> +     * The vGIC does not support routing hardware PPIs to guest. So
> +     * we need to skip any node using PPIs.
> +     */
> +    nirq = dt_number_of_irq(node);
> +
> +    for ( i = 0 ; i < nirq ; i++ )
> +    {
> +        irq_id = platform_get_irq(node, i);
> +
> +        /* PPIs ranges from ID 16 to 31 */
> +        if ( irq_id >= 16 && irq_id < 32 )
> +        {
> +            dt_dprintk(" Skip it(using PPIs)\n");
NIT: missing space after "it". I can fix this on commit.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel