[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86/smpboot: Remove redundant order calculations
On 11.07.2019 17:49, Andrew Cooper wrote: > The GDT and IDT allocations are all order 0, and not going to change. > > Use an explicit 0, instead of calling get_order_from_pages(). This > allows for the removal of the 'order' local parameter in both > cpu_smpboot_{alloc,free}(). > > While making this adjustment, rearrange cpu_smpboot_free() to fold the > two "if ( remove )" clauses. There is no explicit requirements for the > order of free()s. > > No practical change. > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> While I think that it was appropriate for the code to be independent of actual (albeit never changing) sizes, I have to agree that with the context switch side change in it's better to be consistent here. Hence despite my slight dislike Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |