Re: [Xen-devel] [PATCH] x86: Get rid of p2m_host array allocation for HVM guests

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 7/11/19 3:25 PM, Andrew Cooper wrote:
> On 10/07/2019 14:25, Julien Grall wrote:
> > > However, in attempting to review this, I've got some bigger questions.
> > >
> > > All ARM and x86 HVM (and PVH) guests return true for
> > > xc_dom_translated(), so should take the fastpath out of xc_dom_p2m() and
> > > never read from dom->p2m_host[].  Therefore, I don't see why the
> > > majority of this patch is necessary.
> > I agree that p2m_host will never get used by Arm. So this is a waste
> > of memory.
> >
> > >    On the ARM side, this also means
> > > that dom->rambase_pfn isn't being used as intended, which suggests there
> > > is further cleanup/correction to be done here.
> > I am not sure to follow this. Could you expand it?
> dom->rambase_pfn was introduced for ARM, and the code which uses it in
> xc_dom_p2m() is dead (on ARM, not on x86).
>
> It isn't functioning as intended.
I am afraid I still don't follow it... rambase_pfn is used in various 
place in xc_dom_core.c and xc_dom_armzimageloader.c.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel