[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Ping³: [PATCH 1/2] core-parking: interact with runtime SMT-disabling


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Mon, 15 Jul 2019 08:34:19 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1uMY7asc4TqteyDmOd4nTPByM/gEaE6kZ0hJJgNZUA=; b=X8a4OkWXxaeQTXTL8uA3kvCFbV6N+LLu2AEYpGHpM/LXOomxmp0t6jsAi84hMfqRdiqpBesat7MTZW3m4DzPmukco0K6joP/jYlVw/V9/h4O1HO9mUMoz2KV5IzNnhqcMXfiws1Ne0cqdZnKbTieA658McgT8fRgEuGHHQXoMzEB/oZMQ5XryC7JQSEHnA68MH3GKlYQOGxwhKabMyltd5SWps8E56kk7V+h1+2TAMSzwL0J+MpAu9qiXGILqJ+q3/SGweBmVQ2c8GBKfV7dqSp0ojXJmD6pZ7CTB2oSYT/UfYaYlayfRiK3aWyVuzb0N27K8OZJOfDUxTFX0iJRHw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLQykAz9HOWZyG2SYkwvamhD/njEGhOx2L47BFUDcHm/QWMU3IGSQwL0A/tn6rid34A+vLmZQFD1weOGNVJYreEPZbnYOaLWV47Dhnq+gimSjFXrlPfx3ubU5Y0moSCU8QyJC107MxQJgDFib4zaNvH5FJVfMUkEkG6PYqDrkyl4jh6I5/ZZZX90TAcrS19k7F0DMUk91xvfiulDeZJ4ASW2GRmUknhA97TLFUe5SmGhT0H1OaWn8k4Qf/5F6DxPuPXckt+1Q9hbHcuGP3+WS35elvhaOx6UMyo3c+BVz1ud/mtyNPJaiD84c3Rfxu7JxW+AccGWmYtN3aB6BOGmJA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Delivery-date: Mon, 15 Jul 2019 08:54:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVOugY6wPFM0x5E0K43CVQk2y/BQ==
  • Thread-topic: Ping³: [PATCH 1/2] core-parking: interact with runtime SMT-disabling

On 03.07.2019 13:29, Jan Beulich wrote:
>>>> On 27.05.19 at 11:36,  wrote:
>>>>> On 12.04.19 at 13:41,  wrote:
>>>>>> On 11.04.19 at 21:06, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>> On 11/04/2019 13:45, Jan Beulich wrote:
>>>>> When disabling SMT at runtime, secondary threads should no longer be
>>>>> candidates for bringing back up in response to _PUD ACPI events. Purge
>>>>> them from the tracking array.
>>>>>
>>>>> Doing so involves adding locking to guard accounting data in the core
>>>>> parking code. While adding the declaration for the lock take the liberty
>>>>> to drop two unnecessary forward function declarations.
>>>>>
>>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>>
>>>> I can certainly appreciate these arguments, but surely the converse is
>>>> true.  When SMT-enable is used, the newly-onlined threads are now
>>>> eligible to be parked.
>>>
>>> And nothing will keep them from getting parked.
>>>
>>>> At the moment, this looks asymetric.
>>>
>>> It does, but that's a result of core_parking.c only recording CPUs
>>> it has parked, not ones it could park.
>>
>> Did my responses address your concerns?
>>
>> Jan

Ping?

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.