Re: [Xen-devel] Ping: [PATCH v2] timers: limit heap size

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jul 05, 2019 at 04:06:06PM +0000, Jan Beulich wrote:
> >>> On 05.06.19 at 08:51,  wrote:
> > First and foremost make timer_softirq_action() avoid growing the heap
> > if its new size can't be stored without truncation. 64k entries is a
> > lot, and I don't think we're at risk of actually running into the issue,
> > but I also think it's better not to allow for hard to debug problems to
> > occur in the first place.
> > 
> > Furthermore also adjust the code such the size/limit fields becoming
> > unsigned int would at least work from a mere sizing point of view. For
> > this also switch various uses of plain int to unsigned int.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I however wonder whether all this heap timer management plus the extra
list is really the best option, using a balanced tree seems like a
better option here.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel