[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 05/17] xen/arm64: head: Introduce print_reg


  • To: Julien Grall <julien.grall@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Mon, 15 Jul 2019 18:46:57 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=epam.com;dmarc=pass action=none header.from=epam.com;dkim=pass header.d=epam.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/i6bqkAB26aYReFriZ1gVThPStd3ED9InutEigAjJ0=; b=bfgajlGMWOAoTzD4RiozncPXnuLH4mVGoI+YMYMBrI1VnUqcdg8sr+ORvbllBKWlKKWgQRp2mlro4PQ5T+8alQvmdgfaQq0/Bxeb4adyhg+bluFJcz42KlOxxhNvnPj3ZuLP3GPpQzLfDL59KKSCph9o3+ChJ865/DXI/o3RDMIjpRZMoDWqJN50l3xyDwd3A3gsbj5hf71apW7VIGNCZRCqmZkdnAflviX6X0KIKgR0+3gwgl9bcsqWBToLNr0Ni1D/qmjvhs2oEx4MLhgKE3XKV0QIywH46SJFYsfYbEgd1AaJDZkKdrkwDfAcT+KlRQPRE8P7KRzvc3nAiccXrg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHYaO3/BJu+SMW9Qrs6/7msTsSW4wpjpwppHF1ZS5KKAgzbaKpuMfO27ECuJxXioSqlwSUFPbdCkcGcDacHMJxKt4O8kJInnuojbc4Ga+Q8ZfteKbRtNMqWaEITDhVRHS1hqwtKCECo9D5eEAAIeounQybM5xC4nKKyBlToIQ+32MxWQkC5kYCh4UVK19IsRZvlm/0RMVo9DyOAx+7fDdQCmbiKlbes9+GCbWeaQXUq3ZSQrzjcmcBgPDlU1ufNKX3/yEafExMrYYfoycbuBYvr0PzJg/Mm2TP8c8aqQ0c/juj8V5WwHcleQjczqbrqrJpFnwnwNO0ab5/llqHIsGA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrii Anisov <Andrii_Anisov@xxxxxxxx>, "andre.przywara@xxxxxxx" <andre.przywara@xxxxxxx>
  • Delivery-date: Mon, 15 Jul 2019 18:47:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVH8NX5OjaNXd6d0iFM3XX9g6mI6bMO9MA
  • Thread-topic: [Xen-devel] [PATCH 05/17] xen/arm64: head: Introduce print_reg

Hi Julien,

Julien Grall writes:

> At the moment, the user should save x30/lr if it cares about it.
>
> Follow-up patches will introduce more use of putn in place where lr
> should be preserved.
>
> Furthermore, any user of putn should also move the value to register x0
> if it was stored in a different register.
>
> For convenience, a new macro is introduced to print a given register.
> The macro will take care for us to move the value to x0 and also
> preserve lr.
>
> Lastly the new macro is used to replace all the callsite of putn. This
> will simplify rework/review later on.
>
> Note that CurrentEL is now stored in x5 instead of x4 because the latter
> will be clobbered by the macro print_reg.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> ---
>  xen/arch/arm/arm64/head.S | 29 ++++++++++++++++++++++-------
>  1 file changed, 22 insertions(+), 7 deletions(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 84e26582c4..9142b4a774 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -90,8 +90,25 @@
>          bl    puts    ;     \
>          mov   lr, x3  ;     \
>          RODATA_STR(98, _s)
> +
> +/*
> + * Macro to print the value of register \xb
> + *
> + * Clobbers x0 - x4
> + */

Despite its name, this macro can't print x4. I would recommend adding at
least comment about this. Static assertion would be even better, but
looks like we don't have them for asm code.

> +.macro print_reg xb
> +        mov   x4, lr
> +        mov   x0, \xb
> +        bl    putn
> +        mov   lr, x4
> +.endm
> +
>  #else /* CONFIG_EARLY_PRINTK */
>  #define PRINT(s)
> +
> +.macro print_reg xb
> +.endm
> +
>  #endif /* !CONFIG_EARLY_PRINTK */
>
>  /* Load the physical address of a symbol into xb */
> @@ -304,22 +321,20 @@ GLOBAL(init_secondary)
>  #ifdef CONFIG_EARLY_PRINTK
>          ldr   x23, =EARLY_UART_BASE_ADDRESS /* x23 := UART base address */
>          PRINT("- CPU ")
> -        mov   x0, x24
> -        bl    putn
> +        print_reg x24
>          PRINT(" booting -\r\n")
>  #endif
>
>  common_start:
>
>          PRINT("- Current EL ")
> -        mrs   x4, CurrentEL
> -        mov   x0, x4
> -        bl    putn
> +        mrs   x5, CurrentEL
> +        print_reg x5
>          PRINT(" -\r\n")
>
>          /* Are we in EL2 */
> -        cmp   x4, #PSR_MODE_EL2t
> -        ccmp  x4, #PSR_MODE_EL2h, #0x4, ne
> +        cmp   x5, #PSR_MODE_EL2t
> +        ccmp  x5, #PSR_MODE_EL2h, #0x4, ne
>          b.eq  el2 /* Yes */
>
>          /* OK, we're boned. */


--
Best regards, Volodymyr Babchuk
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.