[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v4 09/13] x86/IRQ: make fixup_irqs() skip unconnected internally used interrupts


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Tue, 16 Jul 2019 07:42:53 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8hVC/1ezoY+R3ujgihcV7SxQy/qj+S2tXmHLjdKXNE=; b=fRKB8oeopJeueBu+bpOSXiQtBI2NNwez5DViiUO6B+ygppM8oRuOXZy0/nOeJXq5DZbIaSZw6VNOTBDPHGCg+SrUDc6faT5xpkUNpPqyFhbqQ2vd464G2RUV3KLINV7Tla7K9FWxddVLxPxiq6d4Q1yIWBmBFp6W/MA8qnc7gmD/AGAoZSZ/l94PQQE3zJQmeo6A4VNHXZEDFGCMZTKBWKrT8hTb5cJp9qFXS1hoCE2gsHwCojSBXwO3EtNVyOi5f2cGy1ISVMMgNgmBVhnuxHfI71mZWEXDkylYZVsdc3PTxs42rzyq5pLojIoGSM/I+Gaj9d5af+q2chpSJ9Q2Vw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DgvoSBFmMv7WGLh9/WaZFcOiVcFxrsq5ghLIfK3raBIII5BTzK9AVYCtC8YF4ACshsnZhp14TY5OvkdhdZepLlyv+RWgymbp0U1v6ar+SuDXSesHxEUM8Ur1Uy0GffHO3oQhIBDqHb0t53yXF0Di5JZB6H/ABP1kpTJ1g4VlYHu4qwt0oeEfDNHaOScbnDexredxIlVQ+xk3QlOWNxsu85RY2bGJqFiBXrm9C55ZrLL4m3myZOZXmx8fYMeO3hz1kEaD4Rat6jHBsbwbfz5P0YucRDMxxHySIJulLpo1424FFv0uEK2xEjrXnHrUj6fGPuSSAhrCW0dX267J6YeVBg==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 16 Jul 2019 07:49:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVO6oTaUj7aNLMhEKbfLYrbqP/Jg==
  • Thread-topic: [PATCH v4 09/13] x86/IRQ: make fixup_irqs() skip unconnected internally used interrupts

Since the "Cannot set affinity ..." warning is a one time one, avoid
triggering it already at boot time when parking secondary threads and
the serial console uses a (still unconnected at that time) PCI IRQ.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -2472,8 +2472,20 @@ void fixup_irqs(const cpumask_t *mask, b
          vector = irq_to_vector(irq);
          if ( vector >= FIRST_HIPRIORITY_VECTOR &&
               vector <= LAST_HIPRIORITY_VECTOR )
+        {
              cpumask_and(desc->arch.cpu_mask, desc->arch.cpu_mask, mask);
  
+            /*
+             * This can in particular happen when parking secondary threads
+             * during boot and when the serial console wants to use a PCI IRQ.
+             */
+            if ( desc->handler == &no_irq_type )
+            {
+                spin_unlock(&desc->lock);
+                continue;
+            }
+        }
+
          if ( desc->arch.move_cleanup_count )
          {
              /* The cleanup IPI may have got sent while we were still online. 
*/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.