Re: [Xen-devel] [PATCH v2 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Sent: 15 July 2019 15:39
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Suravee Suthikulpanit 
> <suravee.suthikulpanit@xxxxxxx>; Brian Woods
> <brian.woods@xxxxxxx>; Kevin Tian <kevin.tian@xxxxxxxxx>; Jan Beulich 
> <jbeulich@xxxxxxxx>; Andrew
> Cooper <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>
> Subject: Re: [PATCH v2 1/4] iommu / x86: move call to scan_pci_devices() out 
> of vendor code
> 
> On Mon, Jul 15, 2019 at 01:37:07PM +0100, Paul Durrant wrote:
> > It's not vendor specific so it doesn't really belong there.
> >
> > Scanning the PCI topology also really doesn't have much to do with IOMMU
> > initialization. It doesn't depend on there even being an IOMMU. This patch
> > moves to the call to the beginning of iommu_hardware_setup() but only
> > places it there because the topology information would be otherwise unused.
> >
> > Subsequent patches will actually make use of the PCI topology during
> > (x86) IOMMU initialization.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 

Thanks.

> I would even consider moving the call to scan_pci_devices into
> pci_segments_init instead of doing it in the IOMMU code, as you
> suggest above.

Possibly, although without an IOMMU in the system I don't think there is 
currently a lot of point in populating the pdev list.

  Paul

> 
> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel