[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] mm.h: fix BUG_ON() condition in put_page_alloc_ref()
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 16 Jul 2019 11:27:18 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qe3HOd3K6TjBRw7Mizb3pswzp/hso3ARi18x+rzlbt4=; b=EHYiG1PVjOKU5o4ZSvPXlXgEwba1Obz5T3VXGBScy5cUQ7wNEh0fTuOS/c9INTz9k01ewNYMMrK4Xa4KtV68wJogXG/rCVZ9BI6NG5tOvrryG7g4XBTSlYl3rZeIqFlseaxz7G9ycgVpsfQ/k/lmbQ4IBX/iG1DwoB9dbfwEjKQNdzuJbPfoWv57B2ewlfcswij0zW7PLQYuXvlxJa5JIDPYfbDfNb0i39ujXth45RL2vhbhoZrlaR8KIYTelSqkpPRd5pKygAiXM0Is/recMOS70P6dDPX1sZxBsZtal5oHMXnHB3J1GXgdESKhcZ7fp42lZFokXgbs1/LB/UEvuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZ/JBz4/ZFptuxwJrI4nw9QAqpq7U5jqJwGa7VZVwYI80LkWDWdzLQNyUG/l6ujtcha7NgYECscOQE045933XRM4riDTEAPO7U8jyrFT6Qb/VVdMZdcHqvNg7YTZwlSUvrIZcULvtwLifZMgkz3UX9ZlT9TXXZiF4QnYuroQZ9SjO+KmTehY3JYEgrUIghirXUUYf7zue0BZuVK0xdCNmHfVcsX+FtKWc3s0bAL02appSnr9MmigwTm/0Z4neSZ3ca6ErzYp6lrIYtzY2iA574lf61Gxbned8M1mYQXpU5X/pm6HYIt/03mCwMaVtinC7Qntj4+opWlkeFeCFakkwg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 16 Jul 2019 11:29:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVO8aSoxPbUDtNTECkzLAP8Y27u6bNG0aA
- Thread-topic: [Xen-devel] [PATCH] mm.h: fix BUG_ON() condition in put_page_alloc_ref()
On 16.07.2019 13:05, Paul Durrant wrote:
> The BUG_ON() was misplaced when this function was introduced in commit
> ec83f825 "mm.h: add helper function to test-and-clear _PGC_allocated".
> It will fire incorrectly if _PGC_allocated is already clear on entry. Thus
> it should be moved after the if statement.
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
And indeed I should have noticed during review. Thanks.
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
and in it goes.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
