[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v3 14/14] AMD/IOMMU: process softirqs while dumping IRTs


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Tue, 16 Jul 2019 16:41:21 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=25LfTAvWWkVzqyIJWFpIqZQiv1F85Eut+yxHMyurJnk=; b=Wx+7XCv7GwbkMKPRGRAFhEFHK+89Y/OYNuJNZGSt/UvCAC6tL861LuDnpStt/TjJa0veU+MvGYh4MbF16DUeY1Y4I/t2lZ0AEM2tN0wZCg7jDooOxG2Vik8soYkypAxy5I4g2ypj7h9pv0jcBAnmpTTx2QK0oSWEptnrwAsmfBOFL4ONcGVR5SvG/afp+FHoA8nwGewHabvXzPOhJ2kJ90IcodJnjlXPdevrZKi7uxIyrL3btDHdKf8YOGX0FTj5XL2MOxeqSJsoLpE/LOGdO1WvhvTYcvX4wHDmOcjHbCT8Qq+HdOsYCm1nFLdfksm+ToNp7QLpLiP66AI8BBAZWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHZSy1yAQJjvA/jk5KNUA6JG53/Cr7GZeOsHma0SmB7f+0OXng2zibegBov4v6yJovzJqjKDOmJwjg67IUMNKeFyks/jgO5mckysGMmwwAyYWWcTO8f7Fd24PMsMUNODBy/dh77vLS7XCJgcKQZSat8ZHhiDAJL9ZMcJ7uW6PYOM6RQycmBAWJ99LV741jbNk/p5rZUc79HZC0CLDxL5rE3VYOgVy5ny14DnlPLqzLK+Xp91+9MjgL8CF6Ve1w3FVPixJBLartmQfwYR7/gkbpy6HoFGkFmc0vv4m0/Ug4UhYEzy04AdgrQx8l4XkpOpkzgvaC2AnyMjqS0Qv7x8mA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
  • Delivery-date: Tue, 16 Jul 2019 16:41:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVO/VM0Z1oh+Srj0iEZDBBy+eI4w==
  • Thread-topic: [PATCH v3 14/14] AMD/IOMMU: process softirqs while dumping IRTs

When there are sufficiently many devices listed in the ACPI tables (no
matter if they actually exist), output may take way longer than the
watchdog would like.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v3: New.
---
TBD: Seeing the volume of output I wonder whether we should further
      suppress logging headers of devices which have no active entry
      (i.e. emit the header only upon finding the first IRTE worth
      logging). And while minor for the total volume of output I'm
      also unconvinced logging both a "per device" header line and a
      "shared" one makes sense, when only one of the two can actually
      be followed by actual contents.

--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -22,6 +22,7 @@
  #include <asm/hvm/svm/amd-iommu-proto.h>
  #include <asm/io_apic.h>
  #include <xen/keyhandler.h>
+#include <xen/softirq.h>
  
  struct irte_basic {
      bool remap_en:1;
@@ -917,6 +918,8 @@ static int dump_intremap_mapping(const s
      dump_intremap_table(iommu, ivrs_mapping->intremap_table);
      spin_unlock_irqrestore(&(ivrs_mapping->intremap_lock), flags);
  
+    process_pending_softirqs();
+
      return 0;
  }
  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.