[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V4 1/9] block: add a helper function to read nr_setcs
- To: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Tue, 16 Jul 2019 22:28:30 -0400
- Cc: Damien Le Moal <Damien.LeMoal@xxxxxxx>, "linux-btrace@xxxxxxxxxxxxxxx" <linux-btrace@xxxxxxxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "yuchao0@xxxxxxxxxx" <yuchao0@xxxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, "jaegeuk@xxxxxxxxxx" <jaegeuk@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "kent.overstreet@xxxxxxxxx" <kent.overstreet@xxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 17 Jul 2019 02:28:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Chaitanya,
> This series just replaces the existing accesses without changing
> anything.
>
> So if any of the exiting code has that bug then it will blow up
> nicely.
>
> For future callers I don't mind adding a new check and resend the
> series.
>
> Would you prefer adding a check ?
I checked your call sites and they look fine. Also, I don't think
returning a capacity of 0 on error is going to help us much.
Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
