[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] x86/mm: Provide more useful information in diagnostics
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Wed, 17 Jul 2019 10:15:06 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P6IQW5ss1hndnC8+zrubQezRDVMdkKCZwntGwQD0b40=; b=XVB1Wom8hh14sFPIKOqv4fMj4jnVdq72iEnn2L2HF/YoMufyclNXNCrytjGBIJ5LPnTdrH+9xruoQM3yYOABrVKPBMPxaHC+tMnqTAd15C5J9jtSqE/OtOzWoj7z31LfFEwAk8kyQGPQX/VdZC/Ho66fhY71O+KraWXOuBXOncD42C9vHFRLh6gTpOSey82w3HNaH+MeI0yBe5mB1B+uZVYdMCsgZWTigz3YZ4rLf5nHAjfVJanZ+dhBK2h07XdfPsubYA93ueReLUBELR0NCCSNFY2DUeUp/1x2Kq0K6n4OcPnxHy7BKSZntWLzuNbFB5VH6W1Z6nZ+DnSMhFTRfw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUEr1fEkjyaaXYu0PZKWw+aKeNVTqgBv5s+uOCYRkjoqxkjkFZ6x+bYSxfHSRls7va+31EovSL3+1lAElVgwn4rKuyYQ1ChDB44joxMChzqvkTw/xq7r+t6l42lGckYnT8DTymwiC7k05C59Izy7/5jNmrH08k+jf+5KjpbdrbmuKPGFEZvNS+g9FKq4u1Fk/DHjY14Y69Ss03B80bhVcd6lQgzsrVObMo2uGRkrKu3dOKivlzjB39dUjqDnJqDHnd5g/0EuDa0NfAg5AERfalFpbKgmLnhQvFB1dX9GBaKhlMglojZ67z1TXOln0EOtuP53lnvORrNHvIPmB/FjpA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 17 Jul 2019 10:15:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVO/vkBYpGD+yhuU6ZuthJqP3CWqbOmQYA
- Thread-topic: [PATCH] x86/mm: Provide more useful information in diagnostics
On 16.07.2019 19:28, Andrew Cooper wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1407,7 +1407,8 @@ static int alloc_l1_table(struct page_info *page)
> return 0;
>
> fail:
> - gdprintk(XENLOG_WARNING, "Failure in alloc_l1_table: slot %#x\n", i);
> + gdprintk(XENLOG_WARNING,
> + "Failure in alloc_l1_table: slot %#x, ret %d\n", i, ret);
To make it slightly less output without losing information, in cases
like this I generally prefer "Failure %d in alloc_l1_table: slot %#x\n".
Seeing ...
> @@ -1505,7 +1506,8 @@ static int alloc_l2_table(struct page_info *page,
> unsigned long type)
> }
> else if ( rc < 0 && rc != -EINTR )
> {
> - gdprintk(XENLOG_WARNING, "Failure in alloc_l2_table: slot
> %#x\n", i);
> + gdprintk(XENLOG_WARNING,
> + "Failure in alloc_l2_table: slot %#x, rc %d\n", i, rc);
... this for comparison it is, imo, not relevant to actually have names
of local variables in logged messages.
Preferably with this adjusted
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
