[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC] x86emul: unconditionally deliver #UD for LWP insns


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Wed, 17 Jul 2019 13:07:04 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pePDj41+UxNyeafVIl/3aa8hn4QBgnmCz63epvKj9yU=; b=i4qB11foTXUumO+esrhS/s5c3DQRJaBN4xSICVXyCZ5DTrs/ELaHyqPFIgoCJxqpPb3yk/Ttd4qwo1bCsHiwhOmHfdUjMZ9gYcaowr+iQkM2XuV1FEDH+Dn3h+lol4s5FBMUbPhDOdv8q04JVPPuTRIeh0qAj4+N7MKPGLRJVm/QUC/SW9Sv4VEueqLe2tzHLemOiKcQs4s9D0tKYOhOk6dO/0P2S/lWV7ydQvvt89nrPanchWE9GpbzHYtPngezGIaVYIhajnOap8jNbvvb0PbklE8UblaI62KfzdIyoEatli+P3LjG4gTOVHjeYsJGiGTkzyTZjgRU5Rcr1KWggw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mooYVbEJw1HJcEu9C7bS9aQkBipTm9BlMTI1XFO2ZF4wCZtiqqgvvz2x/gaCfZm7OdoLaZ3sGRXyAqbleMA3gOlA1jD2eb3yZQlclEloM78vqUMubXGBcAjN6gsHS+Byv4It09uE+1aWw730XwxwR4qDtAoiOx9XCA5vVD06nbsLGTiH9etzsb/BGvO5DhL9u3fVtuNN3by7cVv1Fljl+Gg6l83CwPfjKz3v5Xr9QVVf9nqySBzmxIEUMAs6So4Lv1y41NQbzGnGuSj4evi/+29YEHZEkNIMOHyG7ze1PctCV5wqV2LxAeAYoyBpJmzo5QsdbZwiOOL6mBNOPNaHEw==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 17 Jul 2019 13:07:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVPGrBPWLzciEO+UWYWtF8DkKtbabOsLCmgAAXhYA=
  • Thread-topic: [PATCH RFC] x86emul: unconditionally deliver #UD for LWP insns

On 17.07.2019 13:42, Andrew Cooper wrote:
> On 17/07/2019 07:42, Jan Beulich wrote:
>> This is to accompany commit  ("x86/svm: Drop support for AMD's
> 
> 91f86f8634

Hmm, odd - I'm sure I had checked, resulting in the impression that
this didn't get committed yet.

>> Lightweight Profiling").
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
>> ---
>> With AMD apparently having abandoned XOP encoded insns, another option
>> would seem to be to simply wire all unrecognized ones into #UD (rather
>> then returning UNIMPLEMENTED/UNRECOGNIZED).
> 
> There are still some XOP instructions which actually work on Fam17h
> processors, if you ignore CPUID and go blindly executing.
> 
> Given no official statement that XOP is dead, I'd keep the support we
> currently have.

Then my remark wasn't clear enough: I'm not suggesting to rip out
XOP insn support we have. I'm instead considering whether to wire
all unsupported XOP encodings into #UD (rather than return
UNIMPLEMENTED/UNRECOGNIZED for them), not just the LWP ones.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.