|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] printf formatter for pci_sbdf_t
On 17.07.2019 19:06, Andrew Cooper wrote: > On 17/07/2019 15:08, Roger Pau Monné wrote: >> As part of some PCI related cleanup I'm doing, which includes >> expanding the usage of pci_sbdf_t, I'm also planning to add a custom >> printf formatter for pci_sbdf_t [0], so that a SBDF can be printed >> without having to specify four formatters (and pass four parameters) >> each time (%04x:%02x:%02x.%u). >> >> There's been some debate on the previous version about whether the >> formatter should be %pp or %op, and I would like to settle on one of >> them before sending a new version: > > I am firmly opposed to overloading %o. And I am firmly of the opinion that using %o for SBDF is the more natural thing to do. > Nothing about PCI coordinates has anything to do with octal > representation; its mostly hex. The domain and vCPU IDs aren#t pointer-ish either, for example. > And for the record, I'm firmly opposed to overloading %[xuid] as well. I agree that we don#t want to overload any of these. > %p is the only formatter which has magic overloading so far, and > avoiding gaining a second would be of substantial value when it comes to > reading the code. I don't buy this argument. Readability of some of the printk() invocations in Roger's patch was (severely imo) hampered by the need to take addresses of things that could be easily passed by value. Generated code (size) should be taken into consideration here too, as should be the (slightly) larger stack consumption when going the %pp route. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |