[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 18 Jul 2019 13:14:34 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeK+bkWX/ByzEgAvFSf/gZsOW/QBySL3ol4smJqPins=; b=SxGCALfEalCyz3ibPD6hubPDmRZ1RJBxKpkUsInytg7oa/AAdCX3Su5uoRTmvSfxP/Nx9UdVPLaWJG8DBmuZskU/Is04zHritgFYTMIE94PtuI6joGBbFR0XnRWdRVUpvvbZu9EFin+csPPhpWxeRLo7SRXQunMfaaHjJFjwqD056Y2Dlsgp2MejC19qpaR/hWbGzBTRsHTiN9mYi3Fo5lDVgVjs3NO4w0mkuRbPefYj+QwZlL0chkKBRIldz8unVfb84Lcr6CYFNKKc456x0YL2JUxttcoENn4REc2zetMFKb9B86g8AjZfj0rMr3LxjZmIiHuVdsawHbCe8Z8VTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFfGPmwwT5x94/GLOiOBzV9C11dK0Za3/W6v6hUbInpKYEIVOl6cR1S8m9a8VasXo8DOjX3RUWX+SFBPQ7vXsM4FXpSUJaAm65EzFeUmxoV7tJdvLPn8ZA3dBoSLqfDsJ5XvbxxaEBHaDJfeZBxVTCLzymZSow2d8L+22XAIXBlwZD1dcDdWIkh/4y6ugL/u2xzHnbMFyzoOEDpNDZfICDtwwBv3YXGUWqdGSJaix+jTC7zuUwNfVibf8O2NLN7NGFGypa7PVGTWLDY7E8ot246Gj3AgVbWcpIl4+oeZotolt/cA2vp8HAdGZHRc1S2pHYsWcMZ9+gYrI01Vy//0tA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 13:14:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPNaxkDvYm35RQ027yAvXjVGEzqbQNNsAgAAjJviAAAPJgA==
- Thread-topic: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup
On 18.07.2019 14:59, Tamas K Lengyel wrote:
> On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>> On 17.07.2019 21:33, Tamas K Lengyel wrote:
>>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page)
>>> cpu_relax();
>>> nx = x + (1 | PGT_locked);
>>> if ( !(x & PGT_validated) ||
>>> - !(x & PGT_count_mask) ||
>>> - !(nx & PGT_count_mask) )
>>> + !(x & PGT_count_mask) ||
>>> + !(nx & PGT_count_mask) )
>>> return false;
>>> } while ( cmpxchg(&page->u.inuse.type_info, x, nx) != x );
>>
>> Aren't you screwing up indentation here? It looks wrong both in my
>> mail client's view and on the list archives, whereas. Furthermore
>> this is code you've introduced earlier in the series, so it should
>> be got right there, not here.
>
> The style was auto-applied with astyle using the bsd format. In the
> previous patch there were no style-changes applied because it was a
> copy-paste job from the other code location. I rather keep
> code-copying and style fixes separate.
But you're actively breaking Xen style here (and below).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
