Re: [Xen-devel] [PATCH v5 6/6] tools/libxc: add wrapper for PHYSDEVOP_msi_control

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Jul 18, 2019 at 02:12:20AM +0200, Marek Marczykowski-Górecki wrote:
> On Wed, Jul 17, 2019 at 12:21:58PM +0200, Roger Pau Monné wrote:
> > On Wed, Jul 17, 2019 at 03:00:44AM +0200, Marek Marczykowski-Górecki wrote:
> > > Add libxc wrapper for PHYSDEVOP_msi_control introduced in previous
> > > commit.
> > > 
> > > Signed-off-by: Marek Marczykowski-Górecki 
> > > <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > 
> > LGTM, albeit I find the usage of int instead of unsigned int for the
> > SBDF kind of weird, but it's inline with the other functions, so I
> > guess there's a reason for it?
> 
> Yes, it was based on looking at other places. But I don't know if there
> is any specific reason for it.

Anyway, since using unsigned or signed is not really that relevant
here, and seeing how other functions are defined:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

With just a couple of nits: you don't actually need rc, you can just `return
do_physdev_op...`, and you could also initialize physdev_msi_control
at declaration, but I don't have a strong opinion on any of those, so
you can keep the RB regardless.

Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel