[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 18 Jul 2019 14:47:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxGAyCl4LoV/obkF9cFCgym/ZXmayu0eiXUPjHQydhc=; b=g8Ov4X4IoUIFTX5jsT7zJs5wukNeny2FH/ZKQbX/sGI5wfdTwxTElWXmEfJV+xUbZ+z5g+7WOkO0gIutGy93BzUkEKn0KbVPwiPBW3f2pCNmkRFLJq01mouM9GOwYU9LOg4Yp06yi6zijAn4TmAzAJ05B+vBpi1HyJOsQKDyxAxY7FukC64LS1hueG0kN4HFEWsact/RxckU73Vze0WOKYi2wkx3AfpAMcAsyy42badyhQYjtkC+2STprvBLezRayYsCAwDGD6+ptJXFYJfh6ztKqJwDUjP+rPBGktOy8HEfPBV8v4vdZF+4//bSDnU9JScjSDlO+PRxfnu1TPMk9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fecFBCme1XeaMUDvqfgSVvg6QOnjtJjTQ4qQOlGIZE5l+8CBeAXo6c8N21MTZJgAadaBkrA0kFPEjkTYxlkKx66EyqLu1LK3dGD6R3LFFtou5t+w3jjfCpdBkvkK0fEHupQKKSek8xXtK20vwiOd+fXiMUWn7bWawoJ8gRb0TwybEaZZ8yORONzbkcF2/FmAM0Mz/PWvXub9Ts3DvB5Mho5FQDo+uYxaFW3iQJ6PJDCUNTUc2WoYbSQhg0cnjluCHCjq5hi5jxGnl6gRuQ+XOqMngj+XRWiVWmgZoWwnE3p7rtyJ2Zv4XB81up3vLSI22qpc2fcLJigGPYt3UxPEKA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 14:47:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPNaoMN4/6VqHlEm91bwrx18tx6bQMluAgAAkhnuAAARMgIAAAL3BgAAFHgCAAAROh4AACw0AgAACMMeAAAMOAA==
- Thread-topic: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released
On 18.07.2019 16:35, Tamas K Lengyel wrote:
> On Thu, Jul 18, 2019 at 8:28 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> On 18.07.2019 15:47, Tamas K Lengyel wrote:
>>> I feel like we are going in circles and having the same conversations
>>> over and over without really making any headway. You introduced
>>> grabbing the broken extra reference in 0502e0adae2. It is and was
>>> actually unneeded to start with if the proper solution was put in
>>> place, which is what this patch does, reordering things.
>>
>> I'm not complaining about the changes; I'd merely like the description
>> state why they're needed.
>
> OK.
>
>>> It's possible there are other instances where this may still be
>>> broken. Right now I only have bandwidth to test and fix the paths I
>>> use. If that's unacceptable I'm happy to continue development in my
>>> private fork and leave things as-is upstream.
>>
>> Similarly, if there are limitations - fine. But please say so in the
>> description, to avoid giving the impression that the issues have been
>> taken care of altogether.
>
> Fair enough.
And btw - if you just sent an updated description, I think I'd commit
this without further waiting for George to find time to eventually ack
it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
