Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Jul 18, 2019 at 05:12:54PM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, Jul 18, 2019 at 11:29:39AM +0200, Roger Pau Monné wrote:
> > On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote:
> > > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote:
> > > > On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki 
> > > > wrote:
> > > > > diff --git a/xen/drivers/passthrough/pci.c 
> > > > > b/xen/drivers/passthrough/pci.c
> > > > > index e886894..507b3d1 100644
> > > > > --- a/xen/drivers/passthrough/pci.c
> > > > > +++ b/xen/drivers/passthrough/pci.c
> > > > > @@ -845,6 +845,9 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
> > > > >      list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
> > > > >          if ( pdev->bus == bus && pdev->devfn == devfn )
> > > > >          {
> > > > > +            ret = -EBUSY;
> > > > > +            if ( pdev->domain && pdev->domain != hardware_domain )
> > > > > +                break;
> > > > 
> > > > This seems like an unlrelated fix?
> > > > 
> > > > ie: preventing device removal while in use by a domain different than
> > > > dom0?
> > > 
> > > Indeed it may warrant separate commit now.
> > > 
> > > > Note that you don't need the pdev->domain != NULL check, just doing
> > > > pdev->domain != hardware_domain seems enough, since you don't
> > > > dereference the pdev->domain pointer in the expression (unless I'm
> > > > missing other usages below).
> > > 
> > > I don't want to prevent removal if pdev->domain is NULL (if that's even
> > > possible).
> > 
> > But if pdev->domain == NULL, then it's certainly going to be different
> > from hardware_domain, 
> 
> Exactly. And I do _not_ want to hit that break if pdev->domain == NULL.

Oh sorry for being obtuse, you are right. In any case, please send
this as a separate patch.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel