Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Jul 18, 2019, at 7:26 PM, Rich Persaud <persaur@xxxxxxxxx> wrote:
> 
>> On Apr 25, 2019, at 07:41, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
>> 
>> On 4/25/19 12:40 PM, Jan Beulich wrote:
>>>>>> On 18.04.19 at 15:11, <george.dunlap@xxxxxxxxxx> wrote:
>>>>> On 4/18/19 2:52 AM, Daniel P. Smith wrote:
>>>>> This deals with two casting issues for compiling under go 1.11:
>>>>> - explicitly cast to *C.xentoollog_logger for Ctx.logger pointer
>>>>> - add cast to unsafe.Pointer for the C string cpath
>>>>> 
>>>>> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>>>> 
>>>> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>>>> 
>>>> BTW, do you know if this will compile for older versions of go?
>>>> 
>>>> This should be considered for backport as well (cc'ing Jan).
>>> 
>>> Did you mean Ian, this being a tools patch?
>> 
>> I guess so.  Sorry, I didn't realize Ian was doing the tools backports.
>> 
>> -George
> 
> With the golang tools maintainer change completed, is anything further needed 
> for this patch to be merged?

My change to the MAINTAINERS file hasn’t yet been merged; I think it would be 
good to wait until the tools maintainer (who technically is currently the 
maintainer) can Ack the patch.

I’ll ping Ian privately to make sure he doesn’t miss it.

 -George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel