[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Thu, 18 Jul 2019 22:52:51 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fu0yomhnfEwDG8ztDwPIs9ioQ3AEfQWd5umYLB/BSLs=; b=iiLcI1KiG2k9cggcLUoIcW9Oak8sr2UelGb8XNL6CulhQYPFhUuNceWP6dZko7StdIpE76VIorjkgF5nas0+vlF8jCtcnffaKVtHVhVsLf5O0vLOcpwZzeN7uJPQiOtmphL8fUvnEREvCgBgZW9EX9NGGYJGCW/BSoPIhid8PmQz4wDGO7OIljyMCi4FtB+YLbv2O1LapcVtauNZmt4V4lxYDKh3bY0FfMFntbLd8opl+As+Tzvy+n1Y3mxbnX/xG2vGhQUiUZrdX7eMfxY/Qdlv6jG5D9nhNYlKWmogEZkPZN/wq1Ucbf87OJshrFp2JdZ3sGGsG4oNKvdyMxxUvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPry3yKx1nlT7tEKT88qDoahe3vVGYNIwfdbx22U999XBWR2mmpSkCYkwrqgrLiVf5rkOIukS3+IX+fzOp5V+R27P2LfUZVv4tQpTxICa066TlOKiIAfEw44Hgb6OQ0lcBbFkEpwyZkf3KGoTXiCA6pPEWRFeCtTj7Awuin4XoNZG2W8Nqx0WfJ8EMvt0XoCGFwj6J69qmL/g1IykrCgxM0mzmG1EZe/POffaw3W5t1mqM6I31v+CowrwvZF0vj5YPRdg09ZB8dj+4h8uqI7oDZwRz3yhCyaxuD3iJuuCSzcZFlOUF8HPF6+bzVeMMHUTbaIUijs0HHB5gb+HjGl2w==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 22:53:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPbuGcK2cLHKhs06MDcLPQ3t5rw==
- Thread-topic: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> This prepares making the different schedulers vcpu agnostic.
>
Ok, but the scheduler private data is, actually, for all the
schedulers, per-vcpu scheduler data such as, for instance,
struct csched2_vcpu.
After this patch we have (sticking to Credit2 as an example)
csched2_vcpu allocated by a function called csched2_alloc_vdata() but
stored on a per-sched_unit basis.
Similarly, we have an accessor method called csched2_vcpu() which
returns the struct csched2_vcpu which was stored in the per-unit
private space.
But shouldn't then the struct be called csched2_unit, and cited
functions be called csched2_alloc_udata() and csched2_unit()?
Now, I know that these transformation happen later in the series.
And, this time, I'm not asking to consolidate the patches.
However:
- can the changelog of this patch be a little more explicit, not only
informing that this is a preparatory patch, but also explaining
briefly the temporary inconcistency
- could the patches that deal with this be grouped together, so that
they are close to each other in the series (e.g., this patch, the
renaming hunks of patch 10 and patches that are currently 20 to 24)?
Or are there dependencies that I am not considering?
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
