[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 19 Jul 2019 09:18:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kUruGD6hj3uefEcQWStlh8gh2a5qms0HXTQB/3ccb2s=; b=iZxyhUvKmGA5zl6C3Gytw1csfgS4MU4EsoZL5UpXnb25h0T+stMgnXFIYos1BfGHtBp0us5Rm8PPSiaTn6quB360HQudM70LVEOmzG/3e/9SOixYSs7zm3aScHrY0fR/BKWTgFIX5a7m16GFVNDVYUBYn1ouwlnfuXPQWC58hF+8bfHUL+IhOcA6bRZB7aWwCfELFyBnH2t5EA2aEXMlP+LiFIPVHtsPS5GIvpITEQYAIg6SuDhmyOG1c5UKvk/cr2Cc4qU75Bu8gTtDpICOYZmepTEQHBro9cvqoGubDNvOWQEEFbJ7rFED1xB8+gWFoY5pRYYD2Hx8AoQYlz+V2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFZdcdDZlS5hoDl5Bdwf786yyxYE+/g7ioWhckmcgH3AjAOTOEs5psSECu7l1oDgNW7GutJup4Et3MfG1mXHAdayIdf7JkDOPk1QQVfhgPTMI9QU4ddxZgzcrtoiSlt9Oste7XOe2o/mP0BIhpjXzUGztDEKEN2uwKEYdEPv2XJCBuCo3LWQ4OS5IyzRZZEhjaCAiBWKeq0VEHgwpWWMrYFL7WJ2VZRv/ckclJ9zt4db6uzsqM6YhCb/3tj2lq8vuC+6jDnnPfle1/sW4a29Pi8KaLeoFYE7zEUVWkPNr5bWu1jNvkyFerUfA4hNnWAFgvq5mP9TPca0sSUmryN0LQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 09:19:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPhLyGXH0Q4NjDEWXJddchwyDaA==
- Thread-topic: [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation
Since the behavior of "diff -p" to use an unindented label as context
identifier often makes it harder to review patches, make explicit the
requirement for labels to be indented.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -31,6 +31,10 @@ void fun(void)
}
}
+Due to the behavior of GNU diffutils "diff -p", labels should be
+indented by at least one blank. Non-case labels inside switch() bodies
+are preferred to be indented the same as the block's case labels.
+
White space
-----------
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
