Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

[Rich Persaud <persaur@xxxxxxxxx>]

> On Jul 18, 2019, at 10:43, Tamas K Lengyel <tamas@xxxxxxxxxxxxx> wrote:
> 
> Using astyle (http://astyle.sourceforge.net) can greatly reduce the overhead 
> of
> manually checking and applying style-fixes to source-code. The included
> .astylerc is the closest approximation of the established Xen style (including
> styles not formally spelled out by CODING_STYLE but commonly requested).
> 
> Checking the comment styles are not included in the automation.
> 
> Incorporating Xen's exception to the do-while style is only partially 
> possible,
> thus a change is proposed to the CODING_STYLE of moving the brace from "do {"
> to the next line.
> 
> Most of Xen's code-base is non-conforming at the moment: 289 files pass
> unchanged, 876 have some style issues.
> 
> Ideally we can slowly migrate the entire code-base to be conforming, thus
> eliminating the need of discussing and enforcing style issues manually on the
> mailinglist.

Thanks for taking the lead on this, Tamas.  New Xen contributors are unlikely 
to be aware of the style ambiguities discussed in this thread. A frequent topic 
on Xen monthly calls is the lack of time to perform patch reviews.  Automated 
style checking will increase the S/N ratio of xen-devel, reviewer efficiency, 
patch quality from new contributors, and style consistency across Xen trees.  
This automation will complement upcoming static analysis of Xen for functional 
safety compliance.

Rich
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel