[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 19 Jul 2019 16:27:16 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/kizGlzRxv2XOOifzXNA8nKsGkSokYId/UCM/67wDo=; b=JeAaCYDi7Q162tEDLq/NrzzAmZCC6t4YgVwQxDXj86GUtSKZhOmxZZGcRhB/8wbBmiA3nS7GxsLF98R+2T2A+U5TlmLWkwVS0315rcHEJ35AXVZ1NpadsrzDybq2w0S/XlDb+XbBo3ex+tYYs7xbmzc3yE6F+aM7BX3FioLJVloezqc/h7qGJe5c6q0ZL02jtO7UXxqVX+sceSZkUxM/41AaLnRymz6hrDXohUFVrzrBpGpnz8aCoM5sm32pTL4leT6f0yxXOIfinXFN32fDLP5NfzB4eA3SojJ7RZGufnDlDbKKAbIDVVOQ3cqQY+gtgzeIbFwWk8cDKlI0dHwOJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1KUb/ofWVPis249TQfFjXBPBovmprHblo5birEsLavhGpp2P+rNXoTaAzgKskEJ+JSzo7KQ/w45553GBBwgGS1PHvpBWGoG8OhuRsjScAaU+EuE6St2n55BCwoS182E1vpU6bWTUqBLQr3F80vmt9RdwAG4y+Xn8K6Uy0QQBn0kU81jFujGsXXia5cosLiHAhX4ZZ59n0RcQeuoO9aJkUecNjFjGyvT2x1E4GFyiYrJojXpfhM6FOk9bmgfVZgVZiF2R0ObBs3UFXdpv/Ou6hT5PVotp+avmp5FOYShNoLp1RPu70APIKS0EjHrSgviTGMQX7Z7J39dFITHqGQIjQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 16:27:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVO/SBPI6DYZWl7E6KQgqsoIfCTKbSJLKcgAABCYA=
- Thread-topic: [Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register
On 19.07.2019 18:23, Andrew Cooper wrote:
> On 16/07/2019 17:35, Jan Beulich wrote:
>> This also takes care of several of the shift values wrongly having been
>> specified as hex rather than dec.
>>
>> Take the opportunity and
>> - replace a readl() pair by a single readq(),
>> - add further fields.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> CI is happy this time around.
>
> https://gitlab.com/xen-project/people/andyhhp/xen/pipelines/71942193
Hurray.
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks.
> but as a warning, I'm still certain that FEAT() is a fragile, and will
> be liable to break on future compilers, seeing as that seem to be the
> trend for diagnostics.
There's a certain risk, yes.
> I'm also unsure whether it works correctly on signed fields.
I'm sure it wouldn't, but I don't see any signed fields appearing
there.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
