[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 60/60] xen/sched: add scheduling granularity enum
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Fri, 19 Jul 2019 18:31:26 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HhlN4FSpShXD+0Rdz1nf27Y7Or0o4gy9eI1UoqFvBEY=; b=KrnEdpoFpGbGSb+KXHB0d4dq3pm9Y8HD7dOAlGZSPm2AXfe2T7e7X5jGbff1KMmJEKL/ki3t+Nis+iwOFI84i5Uwk4g9wJumsq8sNoHy9duJNEEUxhiW1Yn1AZm6VXx8mzlWbiQy1wP4KNqxsrJnYr8V1zeWvK83UkAYXBHB6zTD/rqW8cEGHz3Z9lYVda3Ou0HebTH8ARQQwjz71kzJzGLpQ2lltXDglhSFbmOe1lcdih4pqiJarsvmM8QGXeUg60uQQFOKZJCP97LoAGgbOfjA4n4VtPLC6jKnt9EQ5Basa4RDoNzdO4SFk/dce6C5wCH+NDBEfPmInFtlBouyfQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0N/FnEKVlLWn4sMMtbycVZA4F9MD0v+0/LlGV6DtDseOJk6awghgtxQp7fPtlyeAWJmUJ4EvIoNOoGTipu3hFoN2GWUBRfCRv+oLnUn/NeT1G//ueWFAgZ09dar7lxD3WrAx9cBIkU8SaPtqq5LAUxT54wkput1Drz+fe/08Sl+eaXDqy7z+GekTZvjk/rSylxFJ3do8xTzlerGMCjoVqywtsUdhpCTJOvoHgdPV8pTFZcUimOso4vMGBKbIwhLAlxV6ZboBKAKYPpsNEj7nWta4fKFh76xsLl5xnlt8c1STQTP1TPdimrMJo8ZcV+04WTj2wrVxSfBJsDiLfByuQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 18:31:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPmAsy+fup8qTeEKAGVaFvbo9Tw==
- Thread-topic: [Xen-devel] [PATCH 60/60] xen/sched: add scheduling granularity enum
On Tue, 2019-05-28 at 12:33 +0200, Juergen Gross wrote:
> Add a scheduling granularity enum ("cpu", "core", "socket") for
> specification of the scheduling granularity. Initially it is set to
> "cpu", this can be modified by the new boot parameter (x86 only)
> "sched-gran".
>
> According to the selected granularity sched_granularity is set after
> all cpus are online.
>
> A test is added for all sched resources holding the same number of
> cpus. Fall back to core- or cpu-scheduling in that case.
>
Might be me (non-native speaker), but this reads weird.
Perhaps the second sentence should have ended with "is that _is_not_
the case" ?
As in, "if it is not the case that all sched resources hold the same
number of cpus, we fallback". While right now it seems to me to say
that we fall back in the case that the resources hold the same number
of cpus...
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
With the above clarified:
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
