[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself
- To: Andrii Anisov <andrii.anisov@xxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 23 Jul 2019 09:12:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AG3TnhYXI209fXJPKeDH638TraIzdEF+1qpZDuFU8P4=; b=E16umIXlLmQC7cJgOCC8CNFZAsaFoByz0vUI7ydUE9xcS4NRxtDZvMQNF4JbgonkdekbtPAFZ+s/LlqifItwPx8Wykxi8oPAguJaK9apetJljDLX6HHWXbEEURPPh61HL7eGobhdUl3+7GeMgz46zjodaQ6hmHamqDDBUaWBhSBuqlo0as9jbNltU17/1jxs55ctCVVzUtDtqzlokKrKTG1+0+usi7fnqheICQwXzOCVNAWd4D3wIEVenboHFrGZWrICf6SA+boLq/ly3h6q0a/PCkJrh3t6fDL3h9NhugdARX4tzzQFq+DEeitZQD0VkfJ+eMJ2o6QMOWWc4DqSnQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8Bc2zkTFtYqTjwLUxLOerptCJKJOYu4o8vmD9/XSe/lP4CfbKP7lIZrzHql9yDLTUGtB3Z1P5H62+jzl/uB/JPkxorp0OwZaJjMeDYdcHksyNMJivnankWegVv/RxeWGkxtrh9wWiw/mTnRXT6hYyHbwWcd9QgYaabHYRo8dfKKbgHqVwXfm4/u7moSpmCMFGCwlDrepAt9zCieuoPpj4OxsqAq4xxMce96Y3yn3KhL6mM4A3YCGyvugjL9P/vDbfVOFn+lnZhQSwyXLMPRH4Yl70OgwqLlaibuj/MBGvDXed+g/J/WvoA7De8EcKH2DZIpdqd+4TXECWgWungjhQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrii Anisov <andrii_anisov@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 23 Jul 2019 09:14:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPhWLg4cyYnQWKUW8aYX9saIQuqbWZDjPgAAOmQCAABvi84AAAicAgAAFXjOAAVSIOoAABo0A
- Thread-topic: [PATCH] vunmap: let vunmap align virtual address by itself
On 23.07.2019 10:48, Andrii Anisov wrote:
> Julien, Jan, Andrew,
>
> The problem addressed by [1] causes random ARM64 boot fails dependent on
> hypervisor code changes.
> Yet more generic solution was requested by Andrew and supported by Julien [2].
>
> How to proceed with this particular patch?
> As I understand, Jan doubts we should move page alignment to vunmap(), while
> Julien and Andrew wanted the commit message clarification.
> Can we have an agreement on approach here?
>
> [1] https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg01167.html
> [2] https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg01129.html
First of all, let me quote Linux'es code:
static void __vunmap(const void *addr, int deallocate_pages)
{
struct vm_struct *area;
if (!addr)
return;
if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
addr))
return;
As long as we aim to have a reasonable level of compatibility of
similar interfaces, we should not go the suggested route.
Beyond that I continue to be of the opinion that it should be
all-or-nothing: Any pointer pointing anywhere at or inside the
region should be accepted, or just the one pointing precisely at
the start.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
