[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] x86/pv: Move async_exception_cleanup() into pv/iret.c
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Wed, 24 Jul 2019 10:22:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zvw1hEBnghJr12Ze5NGAuUZ6lKkvAwqfm2CNjFGFC0Q=; b=m+RIWyZ8E61bRZF3SVPkg8/4LK+ymUN/d6/E/BZ9TXSZGaAK6BSFtLiHpSsd2dEKYBRgM0BAZ8EQ4yX5Vma4K8Q/1kVee+pJXFIwqcWmQEUiwjQ+QWF03+k1WbJcusI/ByNtvF2b6Kuf+4RoqVG3GdyfvmiKkHX+E3Jmwuo1zbJwkohnSz75Sa35/4bdjRDjv5d0YxRMEIGkO5HM/w2Boqm9vMSsn7uxS1aNyN/V4iZbNchwvr9lRv/gyrc1vKxgFZFdfT9PBv8JjrAxqvwGwsrTWbCth/8IEhJO3oNdGz0khuEn7W5bu9QQ7cmcs2AJv0bo1LWfT6+TetcOuxM+fw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAIg3U0ePo2Q+l5Ozj+7HIvXMKKfeywhzIKs80KqiXSO+6yttXWo+M7TH9111ZZCgVrACA25f5ATgks8/ZZgJsaqpxFD63GKZJKgO85PoyYvB8S/8vm+agQMsJ/rDv1XfuJEg/COpgSXLzx66DEuffbaFXRz/QOJt/3xVucHUHOyTDCG1mrG9gmz2dTXdjnMHelzwaNbsiGPcfMPzKifUZAGrV/mWVxJ/kARIMC3i+sTJcRNTfgrOi+be7u9nxOnRps/JneD1lqbpnBTbl7F++ypp4ixLSqu2oHHy36VSHi7llHiNVfb/WkBMq3U6aU/x1J3aVVZOYLanvExcslcWw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Juergen Gross <JGross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 24 Jul 2019 10:23:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQZEPVYSOd4hduEm4xew4+ZUIfabZkFYA
- Thread-topic: [PATCH] x86/pv: Move async_exception_cleanup() into pv/iret.c
On 23.07.2019 21:58, Andrew Cooper wrote:
> All callers are in pv/iret.c. Move the function and make it static.
>
> Even before the pinning cleanup, there was nothing which is specific to
> operating on curr, so rename the variable back to v.
I'm not in full agreement with this: The implication here was (and afaict
still is) that uses of / updates to involved vCPU fields are race free.
Feel free to add my ack if you revert back to curr. Otherwise I'd first
like to hear your contrary opinion.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
