[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Wed, 24 Jul 2019 13:40:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r7et6zN6BoWaR/iD7ggIkpyxff03FwvotY2UX4LPKdQ=; b=MktgPKG6a9D+hBLp0v/RSSkMD5k4kNU2Avxl8+j6QPv7/XAu+e3sGnoL+HDStE1Zcdek0v1TJf3AdkITBW2tdqrX6r6eipxPP43sVY9WaOgDvld/mHEtwcEEQwQoa4C3WfwQx0vYmqgSm9URQ7qGfbAFEuU2javWjcn5deA1Px39e80nJzaLgkvRafyYCuJIGSoZ0XZMZpu8KLTlvgbogWm1iUt6lH6MUuxoKstG1clDUP7yUgEzGqyQrLjbJ+jzFnU4zFiIJIXnDwpYkl0WhfEVRzX59FL+ecT6ZdQx+teipcm33AUWF9iWwinwutAs0839MFYPmBkS+7kz72rP3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6rNykH74xmrJwuXD3zgsWfX+ci91l/GKtkpJ/jePClPHAzYO/PDKjKKnKE112twl7bpWY2pxmcSmYWTnuTHtnHtY2/kg0FR7cLdIHplSGuLYpkV1K+ZdMvW3CkOadLbDHsA1iv/6au0BB154EavfnE85iEOylejCfq+EtEEDdWPz8w26MOq/jojIOtolWMZpcTbwb6IxoZWV37zUy8TGJqELDEvkK5yGxbNlIVoE2WyMCl+46XUKWRc7bEMN2eooyz1d65IfuL9kNP7frRJSpQw58z5s+Z6hMAW10OIJfn9Dfv1O0oYrRkcv2JRz816c+SFxctvWTwP6D5pwocFwg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: KevinTian <kevin.tian@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>
- Delivery-date: Wed, 24 Jul 2019 13:43:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVO7+0vp5IFFxe40a9hOR1TZYA+abZ0zeA
- Thread-topic: [PATCH v3 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code
On 16.07.2019 12:16, Paul Durrant wrote:
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -28,9 +28,15 @@ struct iommu_ops __read_mostly iommu_ops;
>
> int __init iommu_hardware_setup(void)
> {
> + int rc;
> +
> if ( !iommu_init_ops )
> return -ENODEV;
>
> + rc = scan_pci_devices();
> + if ( rc )
> + return rc;
From an abstract POV I'm not convinced failing IOMMU init because
a failed bus scan is appropriate. But the only currently possible
failure is -ENOMEM, in which case we'd be in bigger trouble anyway.
Therefore
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
The other question of course is in how far you can sensibly use
the results of this (incomplete) bus scan later during IOMMU init.
But hopefully that'll become clear from the subsequent patches.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
