[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/3] x86/dmi: Constify quirks data
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 25 Jul 2019 11:59:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDh3WRpUJMZG4f0tUSsFRJmSsz7kj9tTf+z+iTFNHzY=; b=i6+/gEWmqoklbILFInqAja63SS6QUJ6YElNs5qdI2Hb/nPGTfEWQ+Wh1bZKvvXkEtL/cN/t+aYTjIYoohsfvH8q5I+7mmzXgwckXNbSu6qj2rfZM3Z4F8+W267O/RATBP6aZ2Pr+viSLt4HK8u8z775DkfX9yP6rAHZbM8T2fQVroPxWJStOrhDtWkObOi7KHevhFnQc1g+t5kpEEaRB0zPw2aJxVJusYeAj44m9CnLtw8dZzBbxWnyfwV07BNgPlW+BU39ynLPlSTY5ISOqlCt9XGXYJitGC6H5G51m+jgHq+vxHJnQdUNTnrTKIHJpuwcu1uKuccbk+05/SPHapg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VtXPmbttLW0Qxye7sAv2jr/yd8HL+xNpLPCAmBpSPZBGxUM+C7zRKocAfAQLFRTkABgt/wphJTwb7DQASOi76WQdj9ezNEZZa5vcT0p3ctlpCfNZVTCZWctb72nhxm69GTLX9xUzJAP//vGUNVtAhbBXEG0EUnZgN+KI2OgG4gmmSFsa32MR4Qw9APD9j4PkDmXclpffHp6k9AOrvc767cQyJSsT7XLOnHuH73o/jxpueJCCDqEBzO7b9m9j05mf9OWYJ+FNrGMzWH+yQpr99QqIc5oK/SvJqpNmCywWtX7q7TUfcYf74wKukzVQmB8fuA7lo/QFKfjy0gjvLk7ftQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 25 Jul 2019 12:03:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQkdJ4D6dRHL0Jkazew/ijLBoYqbbJWCAgAACvw+AABQlgA==
- Thread-topic: [PATCH 3/3] x86/dmi: Constify quirks data
On 25.07.2019 12:46, Andrew Cooper wrote:
> On 25/07/2019 11:37, Jan Beulich wrote:
>> On 24.07.2019 19:42, Andrew Cooper wrote:
>>> All DMI quirks tables are mutable, but are only ever read.
>>>
>>> Update dmi_check_system() and dmi_system_id.callback to pass a const
>>> pointer,
>>> and move all quirks tables into __initconst.
>> I think you need to use __initconstrel throughout.
>
> Hmm - what's the practical difference? __initconst certainly compiles
> fine for me.
>
> (I've got no vested interest, but I'd like to understand why)
Some compiler versions dislike mixing of .section with the
same name, but different "writable" attributes. When static
initializers involve relocations, the respective section
gets marked writable by the compiler, whereas when they
don't the section would remain readonly. Hence things
generally build fine either way _until_ both an initconst
item with and one without relocations appear in the same CU.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
