[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v4 07/12] AMD/IOMMU: allow enabling with IRQ not yet set up


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Thu, 25 Jul 2019 13:31:47 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+16m4J1UQL0y0DjKMtw2xecGJyRvK95vVAUiGBfATUw=; b=J/8gx1UBoRiOcSU1sAFwdiqKzoEIF1vBZDjX1x6JaK9+nm/zIRjZ1xXIN6Zr9PM8VYRzfsWKLE8o8QEdI5gLUPmDJDQEormDBQUEY33KPpXIobeK8lKz2vuWIgAwIyeENPVck5Z4fjuDhaU9aBrpGc5k2bQbh4QSVAYy9eD2PyMWCjRB5Att62/QP2xpNctPtc+gx3KFHx5MzBi0tm/1iu54gnendseYGrqv9At3w2jragss1OxWaBMikjPPlaKX0KE6eWZl1rCO+/DpQVNXTUTSd139TtZt+xsNaHzTp9Xw3ykscvxCtzbq9tbonUKRkQKCcFEn2fXGl59JTxrj4g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ca8oLKDEm+902raRTguKMvnBT+yjrMdOAmbRaQKsgd5BDCgYKeJBFi0kfyRrnaAQvbbOoUecX0MOa+oXs/1AYOryPCxr8UrJ6rR0CQHAJVSbSO3uwusKPbv4+/Ik++Tfcg4C9R11dzIGXu+SJyR5p2qOcssPtKNCHJ1vQx62eKMNl/xA/cOcohwwFDovj3+IUXOqhePJjmLFbTCOqp8kCPgTXOKCXapL2OdH5chAC7hds21sNxHr6o8taL4wYi68JRJSjVtFsdRYUBbJbzjq39jPwLgfNaRXvYJQIagNkZs0cFLRDQXnalLeJWbndHBLvVaIDAvao5+0KXq9lIKZyA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
  • Delivery-date: Thu, 25 Jul 2019 13:35:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVQu1OpEi140kijkWlFrEVN+FxhA==
  • Thread-topic: [PATCH v4 07/12] AMD/IOMMU: allow enabling with IRQ not yet set up

Early enabling (to enter x2APIC mode) requires deferring of the IRQ
setup. Code to actually do that setup in the x2APIC case will get added
subsequently.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Brian Woods <brian.woods@xxxxxxx>
---
v3: Re-base.

--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -813,7 +813,6 @@ static void amd_iommu_erratum_746_workar
  static void enable_iommu(struct amd_iommu *iommu)
  {
      unsigned long flags;
-    struct irq_desc *desc;
  
      spin_lock_irqsave(&iommu->lock, flags);
  
@@ -833,19 +832,27 @@ static void enable_iommu(struct amd_iomm
      if ( iommu->features.flds.ppr_sup )
          register_iommu_ppr_log_in_mmio_space(iommu);
  
-    desc = irq_to_desc(iommu->msi.irq);
-    spin_lock(&desc->lock);
-    set_msi_affinity(desc, NULL);
-    spin_unlock(&desc->lock);
+    if ( iommu->msi.irq > 0 )
+    {
+        struct irq_desc *desc = irq_to_desc(iommu->msi.irq);
+
+        spin_lock(&desc->lock);
+        set_msi_affinity(desc, NULL);
+        spin_unlock(&desc->lock);
+    }
  
      amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
  
      set_iommu_ht_flags(iommu);
      set_iommu_command_buffer_control(iommu, IOMMU_CONTROL_ENABLED);
-    set_iommu_event_log_control(iommu, IOMMU_CONTROL_ENABLED);
  
-    if ( iommu->features.flds.ppr_sup )
-        set_iommu_ppr_log_control(iommu, IOMMU_CONTROL_ENABLED);
+    if ( iommu->msi.irq > 0 )
+    {
+        set_iommu_event_log_control(iommu, IOMMU_CONTROL_ENABLED);
+
+        if ( iommu->features.flds.ppr_sup )
+            set_iommu_ppr_log_control(iommu, IOMMU_CONTROL_ENABLED);
+    }
  
      if ( iommu->features.flds.gt_sup )
          set_iommu_guest_translation_control(iommu, IOMMU_CONTROL_ENABLED);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.