Re: [Xen-devel] [PATCH] xen/arm: extend fdt_property_interrupts

[Viktor Mitin <viktor.mitin.19@xxxxxxxxx>]

Hi Volodymyr,

On Fri, Jul 26, 2019 at 2:57 PM Volodymyr Babchuk
<Volodymyr_Babchuk@xxxxxxxx> wrote:
>
>
> Hello Vikor,
>
> Viktor Mitin writes:
>
> > xen/arm: extend fdt_property_interrupts to deal with other
> > domain than the hwdom
>
> It is unclear what problem you are facing. Could you please elaborate
> commit message?

Original goal is to merge make_timer_node and make_timer_domU_node functions.
For background discussion please see discussion in mail (also
mentioned in the patch):
[PATCH] xen/arm: merge make_timer_node and make_timer_domU_node
https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg00914.html

> Also, looks like your commit message is formatted incorrectly.
>
Please see below.

> > Tested with aarch64 qemu dom0 and dom0less boot.
> >
> > Suggested-by: Julien Grall <julien.grall@xxxxxxx>
> > Signed-off-by: Viktor Mitin <viktor_mitin@xxxxxxxx>
> >
> > ---
> > See discussion in mail:
> > [PATCH] xen/arm: merge make_timer_node and make_timer_domU_node
> >
> >
> >  xen/arch/arm/domain_build.c | 22 +++++++++++++---------
> >  1 file changed, 13 insertions(+), 9 deletions(-)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 4c8404155a..5f68603392 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -621,17 +621,19 @@ static void __init set_interrupt(gic_interrupt_t 
> > interrupt,
> >   *  "interrupts": contains the list of interrupts
> >   *  "interrupt-parent": link to the GIC
> >   */
> > -static int __init fdt_property_interrupts(void *fdt, gic_interrupt_t *intr,
> > -                                          unsigned num_irq)
> > +static int __init fdt_property_interrupts(const struct kernel_info *kinfo,
> > +                            gic_interrupt_t *intr, unsigned num_irq)
> Wrong indentation there.

Such cases are not defined in the Coding Style document explicitly.
See my clang-format coding style mail.

> >  {
> >      int res;
> > +    uint32_t phandle = is_hardware_domain(kinfo->d) ?
> There is extra space at EOL.
>
> > +                       dt_interrupt_controller->phandle : 
> > GUEST_PHANDLE_GIC;
> >
> > -    res = fdt_property(fdt, "interrupts", intr, sizeof (intr[0]) * 
> > num_irq);
> > +    res = fdt_property(kinfo->fdt, "interrupts",
> There is extra space at EOL.

Will fix that.


Thanks

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel